fix: fail-closed 0pt Stripe payment and order transitions #66
sax3l
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: admin/0pt#66
Reference in New Issue
Block a user
P0 live-payment preparation on fresh canonical main. This PR: (1) does not 200-ack unverified/unmatched Stripe webhooks; (2) binds deposit Checkout metadata to order_id/kind; (3) advances orders only after signed, paid, amount/currency-matching events; (4) never marks balance delivered merely on session creation; (5) removes UI demo fallback that PATCHed in_production after a failed Checkout; (6) requires verified auth on client status PATCH and balance Checkout, blocks client writes to payment-confirmed states, validates transitions, and uses compare-and-set updates. Verified locally: 1041 tests passed / 184 infra tests skipped, typecheck and production build passed; lint remains advisory with pre-existing unrelated errors. No live keys or customer payment state changed. STILL BLOCKED for live enablement: anonymous drafts are not bound to a verified buyer/tenant at checkout; a verified identity alone does not authorize a particular order, and current UI does not carry a production Zitadel session into these APIs. Track remaining owner-binding/SSO and staging paid/unpaid/cancelled E2E in issue #67. Requires independent review and green CI before merge. Stripe refs: https://docs.stripe.com/webhooks?lang=node and https://docs.stripe.com/api/checkout/sessions/create.
fix: do not acknowledge unverified Stripe webhooksto fix: require matching paid Stripe events before order advancementfix: require matching paid Stripe events before order advancementto fix: fail-closed 0pt Stripe payment and order transitionssiax-bot: grön CI.
siax-bot
CI grön. Godkänner.