3 people 175bb8bd92 fix(bookkeeping): book a negative line-pattern rounding diff on 3740 opposite the business side (#1898) (#1994) ...

buildMultiLineMappingResult booked Math.abs(roundingDiff) on the business
side regardless of sign, so a learned line_pattern whose ratios
over-allocate (three 0.3334 ratios on 100.00 kr = 100.02, diff -0.02)
produced an entry off by 2x|diff|. commit_journal_entry rejected it, so
the user saw a failed confirm and, since #1894, an unbalanced prefill.

The 3740 leg now lands on the business side for a positive diff
(under-allocation, unchanged) and on the opposite side for a negative diff
(over-allocation), flipped after the mirror. computeProposalLines gets the
identical rule in the same change to keep the byte-parity contract, and a
5000-amount sweep test pins engine and proposal together. Also reachable
with normalized ratios: 50/50 on 100.03 kr rounds to 50.02 + 50.02.

Closes #1898


Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-08-27 22:23:52 +02:00

..

__tests__

fix(bookkeeping): book a negative line-pattern rounding diff on 3740 opposite the business side (#1898) (#1994)

2026-08-27 22:23:52 +02:00

accruals

fix(accruals): carry origin dimensions onto dissolution entries (#1419)

2026-08-06 10:04:20 +02:00

bas-data

fix(bookkeeping): drop non-standard account 2012, book EF F-skatt on 2013 (#1409) (#1489)

2026-08-10 14:04:08 +02:00

handlers

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

account-backfill.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

account-classifier-client.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

account-classifier-heuristic.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

account-classifier.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

account-descriptions.ts

fix(bookkeeping): remove false 1580 tax-receivable label, let company account names win (#1968)

2026-08-26 23:11:05 +02:00

account-override.ts

feat(mcp): book on custom accounts via account_override; fix kontoplan settings link (#1608)

2026-08-14 01:24:48 +02:00

account-search.ts

fix(bokforing): account search results in the booking dialog search field (#1877) (#1889)

2026-08-25 13:30:03 +02:00

account-validation.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

actor-context-node.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

actor-context.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

bas-account-numbers.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

bas-catalog-client.ts

fix(inbox): surface full BAS catalog in BookDirectlyDialog account picker (#1543)

2026-08-13 00:55:33 +02:00

bas-labels.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

bas-lazy.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

bas-reference.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

booking-mode.ts

fix(supplier-invoices): reverse credit notes on paid kontantmetoden invoices (#1430)

2026-08-06 12:06:00 +02:00

booking-templates.ts

fix(bokforing): account search results in the booking dialog search field (#1877) (#1889)

2026-08-25 13:30:03 +02:00

cancel-orphaned-entry.ts

fix: unignore transactions during categorization (#1683)

2026-08-19 11:00:02 +02:00

category-mapping.ts

fix(mcp): vat_amount in transaction currency + nullable matched_supplier_id (#1842)

2026-08-24 14:43:52 +02:00

charset-repair.ts

fix(bookkeeping): comprehensive chart_of_accounts charset repair (#736)

2026-06-15 23:01:45 +02:00

client-account-names.ts

fix(bookkeeping): correct seeded BAS account names that contradicted engine bookings (#1321)

2026-07-31 08:58:27 +02:00

correction-line-account.ts

Fix/build (#1041)

2026-07-17 00:52:57 +02:00

counterparty-templates.ts

fix(bookkeeping): book a negative line-pattern rounding diff on 3740 opposite the business side (#1898) (#1994)

2026-08-27 22:23:52 +02:00

create-account-prefill.ts

Fix/bank sync bas (#1284)

2026-07-29 13:28:51 +02:00

currency-revaluation.ts

Fix/bank sync bas (#1284)

2026-07-29 13:28:51 +02:00

currency-utils.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

dimension-errors.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

dimension-resolver.ts

fix(accruals): carry origin dimensions onto dissolution entries (#1419)

2026-08-06 10:04:20 +02:00

dimension-rules.ts

fix(accruals): carry origin dimensions onto dissolution entries (#1419)

2026-08-06 10:04:20 +02:00

engine.ts

fix: unignore transactions during categorization (#1683)

2026-08-19 11:00:02 +02:00

entry-lines.ts

fix(reports): stop driving report queries from the unfiltered journal_entry_lines side (#971)

2026-07-10 11:03:28 +02:00

errors.ts

fix: unignore transactions during categorization (#1683)

2026-08-19 11:00:02 +02:00

fiscal-period-warnings.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

fiscal-year-gaps.ts

feat(reconciliation,bokslut): underlag on a balansdag + persisted closing checklist (Reko bilagor, PR 2 + PR 3) (#1873)

2026-08-25 09:34:05 +02:00

fx-line-slot.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

invoice-accounts.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

invoice-entries.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

invoice-payment-lines.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

ledger-line-amount.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

mapping-engine.ts

fix(mcp,bookkeeping): FX-safe mapping-rule VAT + honest nullable output schemas (#1846)

2026-08-24 15:14:21 +02:00

missing-underlag.ts

feat(bookkeeping): dashboard deep link filters verifikat utan underlag server-side (#1840)

2026-08-24 15:06:30 +02:00

no-doc-required.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

own-account-detector.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

payment-sync.ts

fix: similar-sweep currency remediation, security hardening and v1 API fixes (#1215)

2026-07-27 03:34:56 +02:00

proposal-lines.ts

fix(bookkeeping): book a negative line-pattern rounding diff on 3740 opposite the business side (#1898) (#1994)

2026-08-27 22:23:52 +02:00

propose-payment-lines.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

propose-send-lines.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

reminder-fee-entries.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

rot-rut-entries.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

settlement-account.ts

fix(bookkeeping): settle unbound transactions on the company's single enabled cash account (#1831)

2026-08-24 13:26:08 +02:00

slp-lines.ts

feat(supplier-invoices): sarskild loneskatt (SLP) pair on pension premium lines (#1534)

2026-08-12 20:52:47 +02:00

suggest-fiscal-period.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

supplier-invoice-description.ts

Fix/07 27 (#1271)

2026-07-28 19:50:16 +02:00

supplier-invoice-entries.ts

feat(supplier-invoices): sarskild loneskatt (SLP) pair on pension premium lines (#1534)

2026-08-12 20:52:47 +02:00

supplier-payment-lines.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

template-embeddings.ts

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

2026-07-04 15:58:06 +02:00

template-library.ts

fix(bookkeeping): reverse-charge VAT in booking templates is 25% of the base, not 20% (#1494)

2026-08-10 13:59:55 +02:00

template-source-type.ts

Fix/attributes config (#926)

2026-07-08 09:54:46 +02:00

transaction-entries.ts

fix(bookkeeping): book pre-FY bank transactions on the fiscal year's first day (#1828)

2026-08-24 13:19:50 +02:00

use-bas-reference.ts

perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)

2026-08-26 15:07:49 +02:00

validate-period-duration.ts

fix(bookkeeping): allow a first rakenskapsar shorter than 6 months (#1165)

2026-07-25 11:23:18 +02:00

vat-entries.ts

fix(bookkeeping): reverse-charge VAT in booking templates is 25% of the base, not 20% (#1494)

2026-08-10 13:59:55 +02:00

voucher-series-resolver.ts

fix(bookkeeping): journal search finds a voucher by its label, with a spinner while searching (#1808)

2026-08-23 02:33:24 +02:00