Files
accounted/supabase/migrations/20260826120000_get_dashboard_nav_flags.sql
T
4ac7b45c8a perf(layout): dashboard layout in two waves, nav flags as one RPC, local JWT verification (#1946)
The dashboard layout runs on every hard load, hard refresh, company switch
and the 16 router.refresh() sites, and loading.tsx cannot paint until it
resolves. It cost ~20 network calls in 4 sequential waves: a third
getUser() round trip to Supabase Auth (after the proxy's and the route
guard's), the company resolution, then 16 reads including four limit-1
probes whose only job is to decide whether to render the Webshop and
Körjournal nav rows, and an entitlements read that itself ran two waves.

- lib/auth/claims.ts: claimsPinned/userFromClaims extracted from
  require-auth.ts (unchanged) so the dashboard request context shares the
  exact pinning + mapping. getDashboardAuthContext verifies the JWT locally
  and falls back to getUser() only when claims are missing, unpinned or
  unverifiable: the proxy already performed the per-request revocation
  check before the layout runs (same semantics approved for routes on
  2026-07-23).
- Wave 1 (user-keyed, parallel with the company resolution): team
  membership, profile, user preferences and the memberships join, which
  now also supplies the active company's row and role, so the separate
  companies and company_members reads are gone.
- Wave 2 (company-keyed): settings, agent profile, the switcher's settings
  names, entitlements in ONE wave (getCompanyEntitlements takes the
  team_id the join already carries and runs the grants read alongside
  config + subscription), and get_dashboard_nav_flags().
- supabase/migrations/20260826120000_get_dashboard_nav_flags.sql:
  SECURITY INVOKER, STABLE, EXECUTE for authenticated only; RLS applies
  inside. lib/dashboard/nav-flags.ts wraps it with the pre-RPC four-probe
  fallback on PGRST202/42883/42501 (self-hosted not yet migrated, deploy
  ordering) and degrades to hidden rows on any other error.
- tests/pg/dashboard-nav-flags-rpc.pg.test.ts (6): fresh company, active vs
  pending WooCommerce, active Shopify, mileage trips, RLS for a member of
  another company, EXECUTE grants. Unit tests for the wrapper (RPC row,
  single-object payload, each fallback code, other errors) and for the
  entitlements teamId option.

~20 calls / 4 waves -> ~12 calls / 2 waves, 0 auth network calls.

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 15:14:49 +02:00

49 lines
1.8 KiB
PL/PgSQL

-- get_dashboard_nav_flags(p_company_id): the two booleans the dashboard
-- layout needs to decide whether to render the Webshop and Körjournal nav
-- rows, in ONE round trip instead of four limit-1 selects on the critical
-- path of every hard load (woocommerce_connections, shopify_connections,
-- webshop_orders, mileage_trips).
--
-- SECURITY INVOKER: RLS on the four tables applies as usual, so a caller who
-- is not a member of p_company_id sees (false, false), never another
-- company's flags. STABLE: pure reads. EXECUTE only for authenticated.
--
-- Responsiveness plan 2026-08-26, track B4 (dashboard layout diet).
CREATE OR REPLACE FUNCTION public.get_dashboard_nav_flags(p_company_id uuid)
RETURNS TABLE(has_webshop boolean, has_mileage_trips boolean)
LANGUAGE sql
STABLE
SECURITY INVOKER
SET search_path TO 'public'
AS $$
SELECT
(
EXISTS (
SELECT 1 FROM public.woocommerce_connections w
WHERE w.company_id = p_company_id AND w.status = 'active'
)
OR EXISTS (
SELECT 1 FROM public.shopify_connections s
WHERE s.company_id = p_company_id AND s.status = 'active'
)
OR EXISTS (
SELECT 1 FROM public.webshop_orders o
WHERE o.company_id = p_company_id
)
) AS has_webshop,
EXISTS (
SELECT 1 FROM public.mileage_trips m
WHERE m.company_id = p_company_id
) AS has_mileage_trips;
$$;
REVOKE ALL ON FUNCTION public.get_dashboard_nav_flags(uuid) FROM PUBLIC;
REVOKE ALL ON FUNCTION public.get_dashboard_nav_flags(uuid) FROM anon;
GRANT EXECUTE ON FUNCTION public.get_dashboard_nav_flags(uuid) TO authenticated;
COMMENT ON FUNCTION public.get_dashboard_nav_flags(uuid) IS
'Dashboard nav visibility flags (webshop, mileage) for one company in one round trip. SECURITY INVOKER: RLS applies.';
NOTIFY pgrst, 'reload schema';