Files
accounted/app/api/documents/[id]/extraction-status/__tests__/route.test.ts
T
c7a75d069d feat(ai): job-shaped AI service with OpenAI-compatible backend, extraction-first; stop extracting every inbox document twice (#1740)
* feat(ai): job-shaped AI service with OpenAI-compatible backend, extraction-first; stop extracting every inbox document twice

Sovereign plan WS1 PR1 (#1406 Tier 2, extraction-first, aligned with the
AI surface audit).

lib/ai grows a job-shaped service (generateText / generateStructured /
extractFromDocument; no streaming members yet, see plan rule R3):
- services/anthropic-family delegates to the existing createAiClient()
  and sends the exact request literals the inbox extractor sent before
  (request-shape tests deep-equal them), so hosted Bedrock stays
  byte-identical.
- services/openai-compatible talks to any chat-completions endpoint
  (BYO Swedish provider) via Vercel AI SDK 6.x, exact-pinned and
  guarded: images as parts, PDFs rasterized with poppler (AI_PDF_MODE)
  or sent natively, AI_VISION / AI_STRICT_JSON declared, honest skips
  (ai_no_vision, pdf_rasterizer_missing) instead of fake failures.
- config.ts: AI_PROVIDER/AI_BASE_URL/AI_API_KEY/AI_MODEL and per-tier
  AI_*_MODEL with the legacy BEDROCK_* names kept as the same overrides;
  getAiStatus() is the single source of truth for "is AI wired up".
- provider.ts: openai-compatible in the auto-detect chain (after Bedrock
  and the direct API); createAiClient() refuses it loudly.

Document extraction moves onto the service and gets the audit's fixes:
- Inbox documents were extracted TWICE (pipeline A ran inside
  uploadDocument() before the inbox row existed, so its dedupe branch
  never fired; 3 707 + 1 666 calls / 30 d). The inbox now declares
  extractionOwner on the upload, the extension yields, and the inbox
  mirrors its single outcome onto document_attachments from every
  writer (sync, deferred, attach, retry, MCP).
- Every "no extraction will ever happen" outcome is stamped
  (skipped:no_ai_entitlement / ai_unconfigured / system_generated /
  ...); the status route maps the quiet ones to 'disabled' on the first
  poll instead of a 30 s client timeout. Prod showed 309 of the 327
  never-extracted uploads were the paywall working silently.
- Self-generated documents (our own invoice PDFs, payout files) are no
  longer OCR'd.
- Agent invoke answers 503 ai_unconfigured when the deployment has no
  assistant backend, distinct from the paywall.

Guard: new direct-ai-client antipattern check (shrink-only allowlist of
the pre-abstraction SDK callers) plus exact pins for @anthropic-ai/sdk,
ai and @ai-sdk/openai-compatible.

Verified: 15 958 unit tests green, guards, lint ratchet, typecheck, and a
live smoke against hosted Bedrock through the new service (ping, streamed
tool turn, thinking+cache, PDF extraction).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(ai): make AI_API_KEY optional for OpenAI-compatible endpoints (keyless local model servers)

A local model server (llama.cpp's server, Ollama /v1, LM Studio, vLLM)
usually has no auth. Before, the OpenAI-compatible backend required both
AI_BASE_URL and AI_API_KEY to count as configured, so running Accounted on a
local model meant setting a meaningless placeholder key.

- resolveAiProvider / hasAiCredentials: a base URL alone is now enough.
- services/openai-compatible: only send Authorization: Bearer when AI_API_KEY
  is set, so a keyless server is never handed an empty bearer; a hosted
  provider that needs a key still sets it.
- Docs (SELF-HOSTING Option 3: local-model example, key marked optional),
  DECISIONS.

Verified: with no AI_API_KEY, just AI_BASE_URL + AI_MODEL, getAiStatus()
reports configured=true / provider=openai-compatible (live). lib/ai suite
71 green; tsc, guards, lint clean. Bedrock/Anthropic logic unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 19:39:08 +02:00

101 lines
4.1 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { createQueuedMockSupabase, createMockRequest, parseJsonResponse } from '@/tests/helpers'
const { supabase, enqueue, reset } = createQueuedMockSupabase()
let unauthorized = false
vi.mock('@/lib/api/with-route-context', () => ({
withRouteContext: (_op: string, handler: (req: unknown, ctx: unknown, extra: unknown) => unknown) => {
return async (req: unknown, extra: unknown) => {
if (unauthorized) {
return new Response(JSON.stringify({ error: 'Unauthorized' }), { status: 401 })
}
return handler(req, { supabase, companyId: 'company-1', user: { id: 'user-1' } }, extra)
}
},
}))
const aiStatusMock = vi.fn()
vi.mock('@/lib/ai', () => ({
getAiStatus: () => aiStatusMock(),
}))
import { GET, deriveExtractionStatus } from '../route'
const params = { params: Promise.resolve({ id: 'doc-1' }) }
beforeEach(() => {
vi.clearAllMocks()
reset()
unauthorized = false
aiStatusMock.mockReturnValue({ configured: true })
})
describe('deriveExtractionStatus', () => {
const base = { extracted_at: '2026-08-20T10:00:00Z', extracted_data: null, extraction_model: null }
it('is running while unstamped on a configured deployment', () => {
expect(deriveExtractionStatus({ ...base, extracted_at: null }, true)).toBe('running')
})
// The self-host "no key yet" case: answer on the first poll, no 30 s hang.
it('is disabled while unstamped on an unconfigured deployment', () => {
expect(deriveExtractionStatus({ ...base, extracted_at: null }, false)).toBe('disabled')
})
it('is succeeded when data landed', () => {
expect(deriveExtractionStatus({ ...base, extracted_data: { a: 1 } }, true)).toBe('succeeded')
})
it('maps the quiet skips (paywall, unconfigured, sandbox, opt-out, system) to disabled', () => {
for (const m of [
'skipped:no_ai_entitlement',
'skipped:ai_unconfigured',
'skipped:sandbox',
'skipped:client_opt_out',
'skipped:system_generated',
]) {
expect(deriveExtractionStatus({ ...base, extraction_model: m }, true)).toBe('disabled')
}
})
it('maps every other skip to unsupported and failures to failed', () => {
expect(deriveExtractionStatus({ ...base, extraction_model: 'skipped:unsupported_mime' }, true)).toBe('unsupported')
expect(deriveExtractionStatus({ ...base, extraction_model: 'skipped:ai_no_vision' }, true)).toBe('unsupported')
expect(deriveExtractionStatus({ ...base, extraction_model: 'failed:no_raw_text' }, true)).toBe('failed')
expect(deriveExtractionStatus({ ...base, extraction_model: null }, true)).toBe('failed')
})
})
describe('GET /api/documents/:id/extraction-status', () => {
it('returns 401 when unauthenticated', async () => {
unauthorized = true
const res = await GET(createMockRequest('/api/documents/doc-1/extraction-status'), params)
const { status } = await parseJsonResponse(res)
expect(status).toBe(401)
})
it('returns 404 for an unknown document', async () => {
enqueue({ data: null })
const res = await GET(createMockRequest('/api/documents/doc-1/extraction-status'), params)
const { status } = await parseJsonResponse(res)
expect(status).toBe(404)
})
it('returns the derived status', async () => {
enqueue({ data: { id: 'doc-1', extracted_at: '2026-08-20T10:00:00Z', extracted_data: null, extraction_model: 'skipped:no_ai_entitlement' } })
const res = await GET(createMockRequest('/api/documents/doc-1/extraction-status'), params)
const { status, body } = await parseJsonResponse<{ data: { status: string } }>(res)
expect(status).toBe(200)
expect(body.data.status).toBe('disabled')
})
it('answers disabled immediately on an unconfigured deployment', async () => {
aiStatusMock.mockReturnValue({ configured: false })
enqueue({ data: { id: 'doc-1', extracted_at: null, extracted_data: null, extraction_model: null } })
const res = await GET(createMockRequest('/api/documents/doc-1/extraction-status'), params)
const { body } = await parseJsonResponse<{ data: { status: string } }>(res)
expect(body.data.status).toBe('disabled')
})
})