Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
95 lines
4.3 KiB
TypeScript
95 lines
4.3 KiB
TypeScript
/**
|
|
* Tests for the extension's registry-exposed commit services: specifically the
|
|
* VAT "send for signing" chain (POST /utkast → PUT /las → signeringslänk), the
|
|
* SKATTEVERKET_ENABLED flag gate, and SkatteverketAuthError → recoverable
|
|
* mapping. The op-lifecycle translation is covered separately in
|
|
* lib/pending-operations/__tests__/skatteverket-executors.test.ts.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
|
|
|
const mockSkvRequest = vi.fn()
|
|
vi.mock('../lib/api-client', async (importOriginal) => {
|
|
const actual = (await importOriginal()) as Record<string, unknown>
|
|
return { ...actual, skvRequest: (...a: unknown[]) => mockSkvRequest(...a) }
|
|
})
|
|
|
|
const mockBuildMomsuppgift = vi.fn()
|
|
vi.mock('../lib/declaration-prep', async (importOriginal) => {
|
|
const actual = (await importOriginal()) as Record<string, unknown>
|
|
return { ...actual, buildMomsuppgift: (...a: unknown[]) => mockBuildMomsuppgift(...a) }
|
|
})
|
|
|
|
vi.mock('../lib/audit', () => ({ writeSkatteverketAudit: vi.fn() }))
|
|
|
|
vi.mock('@/lib/extensions/context-factory', () => ({
|
|
createExtensionContext: () => ({
|
|
supabase: {},
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
settings: { set: vi.fn().mockResolvedValue(undefined) },
|
|
log: { error: vi.fn(), warn: vi.fn(), info: vi.fn() },
|
|
}),
|
|
}))
|
|
|
|
import { skatteverketExtension } from '../index'
|
|
import { SkatteverketAuthError } from '../lib/api-client'
|
|
|
|
type SkvSubmitFn = (
|
|
supabase: unknown, userId: string, companyId: string, params: Record<string, unknown>,
|
|
) => Promise<{ ok: boolean; code?: string; recoverable?: boolean; signing_url?: string }>
|
|
|
|
const commitSubmitVatDeclaration = skatteverketExtension.services!.commitSubmitVatDeclaration as unknown as SkvSubmitFn
|
|
const VAT_PARAMS = { period_type: 'monthly', year: 2025, period: 3 }
|
|
|
|
let prevEnv: string | undefined
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
prevEnv = process.env.SKATTEVERKET_ENABLED
|
|
process.env.SKATTEVERKET_ENABLED = 'true'
|
|
mockBuildMomsuppgift.mockResolvedValue({
|
|
redovisare: '165560000000', redovisningsperiod: '202503', momsuppgift: { summaMoms: 150 },
|
|
})
|
|
})
|
|
afterEach(() => {
|
|
if (prevEnv === undefined) delete process.env.SKATTEVERKET_ENABLED
|
|
else process.env.SKATTEVERKET_ENABLED = prevEnv
|
|
})
|
|
|
|
describe('commitSubmitVatDeclaration', () => {
|
|
it('flag off → recoverable EXTENSION_DISABLED, zero SKV calls', async () => {
|
|
delete process.env.SKATTEVERKET_ENABLED
|
|
const result = await commitSubmitVatDeclaration({}, 'user-1', 'company-1', VAT_PARAMS)
|
|
expect(result).toMatchObject({ ok: false, code: 'EXTENSION_DISABLED', recoverable: true })
|
|
expect(mockSkvRequest).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('happy path: POST /utkast then PUT /las → ok with signing_url', async () => {
|
|
mockSkvRequest
|
|
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ kontrollResultat: { status: 'OK' } }) }) // utkast
|
|
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ signeringsLank: 'https://skv.test/sign/abc' }) }) // las
|
|
|
|
const result = await commitSubmitVatDeclaration({}, 'user-1', 'company-1', VAT_PARAMS)
|
|
|
|
expect(result).toMatchObject({ ok: true, signing_url: 'https://skv.test/sign/abc' })
|
|
expect(mockSkvRequest).toHaveBeenCalledTimes(2)
|
|
// call order: utkast (POST) before las (PUT)
|
|
expect(mockSkvRequest.mock.calls[0][2]).toBe('POST')
|
|
expect(mockSkvRequest.mock.calls[0][3]).toMatch(/^\/utkast\/165560000000\/202503$/)
|
|
expect(mockSkvRequest.mock.calls[1][2]).toBe('PUT')
|
|
expect(mockSkvRequest.mock.calls[1][3]).toMatch(/^\/las\/165560000000\/202503$/)
|
|
})
|
|
|
|
it('utkast rejected by SKV → non-recoverable, no /las call', async () => {
|
|
mockSkvRequest.mockResolvedValueOnce({ ok: false, status: 400, text: async () => 'bad rutor' })
|
|
const result = await commitSubmitVatDeclaration({}, 'user-1', 'company-1', VAT_PARAMS)
|
|
expect(result).toMatchObject({ ok: false, recoverable: false, http_status: 400 })
|
|
expect(mockSkvRequest).toHaveBeenCalledTimes(1) // never reached /las
|
|
})
|
|
|
|
it('SkatteverketAuthError → recoverable SKATTEVERKET_NOT_CONNECTED', async () => {
|
|
mockSkvRequest.mockRejectedValueOnce(new SkatteverketAuthError('ingen anslutning', 'NOT_CONNECTED'))
|
|
const result = await commitSubmitVatDeclaration({}, 'user-1', 'company-1', VAT_PARAMS)
|
|
expect(result).toMatchObject({ ok: false, code: 'SKATTEVERKET_NOT_CONNECTED', recoverable: true })
|
|
})
|
|
})
|