* feat(bookkeeping): edit the lines of a proposed kontering via Andra rader
Proposal views (AI suggestion, static template, counterparty template with
or without a line pattern) previously offered only accept-or-start-over: the
verifikation preview was pure rendering and the only line-editable path was
library templates. This adds an "Andra rader" affordance to the proposal
view in QuickReviewDialog that hands the COMPUTED lines (accounts, SEK
amounts, VAT legs, exactly what the preview shows) into
TransactionBookingDialog / JournalEntryForm as an editable prefill, reusing
the same initialLines mechanism library templates already use.
- lib/bookkeeping/proposal-lines.ts: line computation extracted from
JournalEntryPreview into computeProposalLines() (single source for preview
and prefill, so they cannot drift) plus proposalLinesToFormLines() mapping
to the JournalEntryForm prefill shape. The settlement leg is flagged so
the booking dialog swaps in the transaction's resolved cash account and
stamps currency metadata, mirroring buildInitialLinesFromTemplate.
- JournalEntryPreview now renders computeProposalLines() output unchanged.
- TransactionBookingDialog accepts proposalLines (takes precedence over
preselectedTemplate); the booking still goes through JournalEntryForm's
normal manual validation and the engine, no validation bypassed.
- Ore rounding funnels through roundOre(); guard baseline ratcheted down.
- New strings in messages/sv.json and messages/en.json (tx_quick_review).
- Unit tests for all three proposal branches incl. VAT legs, reverse
charge, multi-line patterns, 3740 rounding diff and FX metadata.
Fixes#1878
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(bookkeeping): make the Andra rader prefill engine-exact (skeptic findings)
Three skeptics refuted the first cut of #1878: the extracted preview math
was a lossy approximation of the engine, and making it bookable made every
loss a real booking defect. This commit closes each refuted scenario by
mirroring the exact engine path per proposal branch:
- Balance: VAT is single-rounded and the net leg is gross minus that VAT
(transaction-entries.ts semantics). Independently rounded net+VAT went
off by 1 ore for 12% grosses at 14 mod 28 ore (e.g. 102.06, 100.94),
prefillling an unbookable verifikat.
- 'Ingen moms' deviation: the dialog resolves the UI 'none' sentinel via
resolveExplicitVat before computing lines, so an explicit no-VAT choice
prefills no VAT line instead of re-deriving the 25% category default
into a bookable 2641 leg (ruta 48 inflation on e.g. loan repayments).
- Ore parity: engineRound (plain Math.round(x*100)/100, matching the
engine) replaces roundOre where the engine is naive; roundOre kept only
where the engine uses it (category VAT leg). No more 1-ore drift between
preview, prefill and the booked verifikat (8.62 RC, 34.30@12%).
- Legacy counterparty pairs: new counterpartyLegacy mode mirrors the
legacy booking path: reverse charge emits the 2645/2614 fiktiv-moms pair
(previously dropped: an RC expense would have booked without fiktiv
moms, understating rutor 30/48), VAT on expenses only, income gross, and
sign-mismatched matches mirrored like buildLegacyMismatchResult.
- Pattern mirror: sign-mismatched line patterns flip learned sides like
buildMultiLineMappingResult; ratio allocation filters business/tax types.
- Entity accounts: static template accounts resolve debit/credit_account_ab
for aktiebolag (resolveTemplateAccountsForEntity), so an AB no longer
previews or books EF-only accounts like 2013.
- Settlement swap: only a literal-1930 settlement leg is swapped to the
resolved cash account (applySettlementAccount parity); learned non-1930
money legs (1510/2440/2890/19xx) stay authoritative.
- FX: QuickReviewDialog hands its enriched transaction row to the booking
dialog so the settlement leg's exchange_rate metadata matches the rate
the SEK amounts were computed with.
34 unit tests incl. every skeptic counterexample; guard baseline ratcheted
to 622 (below main's 626).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(bookkeeping): line-pattern settlement leg uses the learned legacy pair (skeptic refutation)
Two independent skeptics refuted the pattern branch: the engine books the
money leg on the counterparty template's learned legacy account (credit
for an expense, debit for an income, mirror-swapped, falling back to
1930), while the preview/prefill defaulted to 1930. A SIE-learned
pattern settling on 2440 showed kredit 1930 in the preview but booked
kredit 2440 on confirm. QuickReviewDialog now passes the learned pair
raw (no entity resolution, engine parity) and computeProposalLines
selects the settlement account exactly like buildTransactionEntryLines;
the literal-1930 swap to the resolved cash account is unchanged.
CodeRabbit findings declined deliberately (see DECISIONS.md): the 3740
rounding line keeps the engine's business-side placement for both diff
signs (parity contract; an unbalanced set is rejected at commit), and
the naiveOreRound baseline stays at 622 (engineRound is a documented
parity exception).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Mattsson
0bb482bf6e