Files
accounted/components/deadlines/UpcomingDeadlinesWidget.tsx
T
Jakob Wennberg 36e3f6ceb0 Design critique: normalize daily-operator flows + UX improvements (#741)
* style(design): normalize daily-operator flows to locked design system

Sweep the dashboard, transactions, reconciliation, invoicing and supplier
flows for design-system violations (.claude/rules/design.md):

- font-medium removed from Hedvig display headings/numerals
- font-mono -> tabular-nums on monetary values (voucher ids stay mono)
- raw Tailwind status colors -> Badge variants / muted-alert pattern
- semantic colors removed from chrome backgrounds (deadline widgets, icon halos)
- hand-rolled skeletons/empty-states -> Skeleton / EmptyState primitives
- opacity-suffixed borders, the invisible warning-foreground count color, and
  shadow-sm/rounded-xl on non-overlay surfaces normalized

The four files that also received UX changes carry their token fixes in the
following commit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(ux): clearer dashboard CTA, match confidence, AI provenance, invoice actions

Four high-impact UX fixes from the design critique (these files also carry their
design-system token normalization):

- Dashboard: render the next-best-action hero for every agent-built company, not
  only 'slim' nav density, so there is always one obvious next step instead of
  four equal-weight metric tiles.
- Reconciliation: surface the match engine's 0-1 confidence as a graded strength
  badge (Stark / Trolig / Svag traff) in the shared verifikat picker rows and
  selected chip; drop the uninformative binary "Foreslagen traff" badge from the
  match dialog.
- Supplier inbox: show AI-filled provenance per extracted field (a success dot
  that clears once the user verifies/edits the value) so misparsed amounts/dates
  get proofread before they post to an immutable verifikat.
- Invoice detail: keep each status's primary action only in the header row; the
  sidebar "Status actions" card now holds secondary/reversible actions only
  (makulera, ta bort, skapa kreditnota, manual-send alternative), removing the
  duplicated CTAs and closing a viewer-permission gap on the old sidebar buttons.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(ux): Tier-B medium design-critique fixes across daily-operator flows

- Reconciliation: standardise the match-confirm verb on "Matcha" (was "Koppla"
  in MatchVoucherDialog) and replace the hand-rolled date <input>s in the bank
  reconciliation view with the Input primitive.
- Supplier inbox: fold the two alternative bookings (Skapa leverantorsfaktura /
  Bokfor som verifikat) behind a single "Andra satt att bokfora" dropdown so the
  default path (Matcha mot transaktion) stays the lone primary action.
- Duplicate-payment guard: demote the "Skapa ny verifikation anda" escape hatch
  to a ghost button so the safe "Koppla till befintlig" path dominates.
- Onboarding: raise the "start fresh" escape hatch from a muted text link to a
  visible secondary button; normalise the checklist's off-scale spacing.
- Supplier flows: finish the font-mono -> tabular-nums sweep on monetary values
  in the supplier-invoice detail / create / review surfaces (ids stay mono).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(deadlines): keep overdue rows visually distinct (destructive chrome is allowed)

The Tier-A normalization stripped all semantic-color row tints from the deadline
widgets, but design.md exempts --destructive ("only --destructive survives in
chrome"). Restore a subtle bg-destructive/5 on OVERDUE rows so missed tax/AGI
deadlines (-> skattetillagg) stay noticeable in a list scan; action-needed
(warning) rows stay clean since warning is data-only. Surfaced by the Swedish
compliance review on #741.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(reconciliation): hide match-strength badge on already-matched verifikat

Per the Swedish compliance review on #741: a green "Stark traff" confidence badge
rendered alongside "Redan matchad" could visually nudge an accidental double-match
of a posted verifikat (a BFL 5 kap audit-trail concern). Suppress the strength
badge when linked_transaction_count > 0 so "Redan matchad" is the lone signal
there; N:1 matching stays an explicit opt-in.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 14:23:33 +02:00

214 lines
7.7 KiB
TypeScript

'use client'
import { useState } from 'react'
import Link from 'next/link'
import { useTranslations } from 'next-intl'
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus } from '@/types'
import {
getUpcomingDeadlines,
STATUS_LABELS,
} from '@/lib/calendar/utils'
import { Calendar, ChevronRight, AlertTriangle, Clock, Check, Send, Loader2 } from 'lucide-react'
interface UpcomingDeadlinesWidgetProps {
deadlines: Deadline[]
maxItems?: number
onStatusChange?: (deadlineId: string, newStatus: DeadlineStatus) => void
}
export function UpcomingDeadlinesWidget({ deadlines, maxItems = 5, onStatusChange }: UpcomingDeadlinesWidgetProps) {
const { toast } = useToast()
const t = useTranslations('upcoming_deadlines')
const [updatingId, setUpdatingId] = useState<string | null>(null)
// Get upcoming deadlines (next 7 days) + any needing attention
const upcomingDeadlines = getUpcomingDeadlines(deadlines, 7)
const actionNeededDeadlines = deadlines.filter(
(d) => !d.is_completed && d.status === 'action_needed'
)
const overdueDeadlines = deadlines.filter(
(d) => !d.is_completed && d.status === 'overdue'
)
// Combine and sort (overdue first, then action_needed, then upcoming)
const displayDeadlines = [...overdueDeadlines, ...actionNeededDeadlines, ...upcomingDeadlines]
.filter((d, i, arr) => arr.findIndex((x) => x.id === d.id) === i) // Remove duplicates
.slice(0, maxItems)
const overdueCount = overdueDeadlines.length
const actionNeededCount = actionNeededDeadlines.length
if (displayDeadlines.length === 0) {
return null
}
const formatDate = (dateStr: string) => {
const date = new Date(dateStr)
const today = new Date()
const tomorrow = new Date(today)
tomorrow.setDate(tomorrow.getDate() + 1)
if (date.toDateString() === today.toDateString()) {
return t('today')
}
if (date.toDateString() === tomorrow.toDateString()) {
return t('tomorrow')
}
return date.toLocaleDateString('sv-SE', { day: 'numeric', month: 'short' })
}
const handleStatusChange = async (deadlineId: string, newStatus: DeadlineStatus) => {
setUpdatingId(deadlineId)
try {
const response = await fetch(`/api/deadlines/${deadlineId}/status`, {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ status: newStatus }),
})
if (!response.ok) {
const data = await response.json()
throw new Error(data.error || 'Failed to update status')
}
toast({
title: t('toast_status_updated'),
description: t('toast_status_updated_description', { status: STATUS_LABELS[newStatus].toLowerCase() }),
})
// Notify parent component
onStatusChange?.(deadlineId, newStatus)
} catch (error) {
toast({
title: error instanceof Error ? error.message : t('toast_status_update_failed'),
variant: 'destructive',
})
} finally {
setUpdatingId(null)
}
}
const getStatusBadgeVariant = (status: DeadlineStatus): 'default' | 'secondary' | 'destructive' | 'warning' => {
switch (status) {
case 'overdue': return 'destructive'
case 'action_needed': return 'warning'
case 'submitted':
case 'confirmed': return 'default'
default: return 'secondary'
}
}
return (
<Card>
<CardHeader className="pb-2">
<div className="flex items-center justify-between">
<CardTitle className="text-lg flex items-center gap-2">
<Calendar className="h-5 w-5" />
{t('title')}
</CardTitle>
<div className="flex gap-2">
{overdueCount > 0 && (
<Badge variant="destructive">{t('overdue_badge', { count: overdueCount })}</Badge>
)}
{actionNeededCount > 0 && (
<Badge variant="warning">{t('action_needed_badge', { count: actionNeededCount })}</Badge>
)}
</div>
</div>
</CardHeader>
<CardContent className="space-y-2">
{displayDeadlines.map((deadline) => {
const isUpdating = updatingId === deadline.id
return (
<div
key={deadline.id}
className={`flex items-center justify-between p-2 rounded-lg ${
deadline.status === 'overdue' ? 'bg-destructive/5' : ''
}`}
>
<div className="flex items-center gap-2 min-w-0 flex-1">
{deadline.status === 'overdue' ? (
<AlertTriangle className="h-4 w-4 text-destructive flex-shrink-0" />
) : deadline.status === 'action_needed' ? (
<Clock className="h-4 w-4 text-warning-foreground flex-shrink-0" />
) : (
<Clock className="h-4 w-4 text-muted-foreground flex-shrink-0" />
)}
<div className="min-w-0 flex-1">
<p className="text-sm font-medium truncate">{deadline.title}</p>
<div className="flex items-center gap-2">
<p className="text-xs text-muted-foreground">
{formatDate(deadline.due_date)}
{deadline.due_time && ` ${t('time_prefix')} ${deadline.due_time.slice(0, 5)}`}
</p>
{deadline.tax_deadline_type && (
<Badge variant="outline" className="text-xs px-1 py-0">
{t('tax_badge')}
</Badge>
)}
</div>
</div>
</div>
<div className="flex items-center gap-2 flex-shrink-0">
{/* Status badge */}
<Badge variant={getStatusBadgeVariant(deadline.status)} className="text-xs">
{STATUS_LABELS[deadline.status]}
</Badge>
{/* Quick action buttons for tax deadlines */}
{deadline.tax_deadline_type && !['submitted', 'confirmed'].includes(deadline.status) && (
<Button
variant="ghost"
size="sm"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
title={t('mark_as_submitted')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Send className="h-3.5 w-3.5" />
)}
</Button>
)}
{deadline.status === 'submitted' && (
<Button
variant="ghost"
size="sm"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'confirmed')}
title={t('mark_as_confirmed')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Check className="h-3.5 w-3.5" />
)}
</Button>
)}
</div>
</div>
)
})}
<Link href="/deadlines" className="block">
<Button variant="ghost" className="w-full justify-between mt-2">
{t('view_all')}
<ChevronRight className="h-4 w-4" />
</Button>
</Link>
</CardContent>
</Card>
)
}