f9ea9c0082
* fix(invoices): apply configured voucher series to payments + preview next voucher The booking engine resolves the series from default_voucher_series_per_source_type, but the global "Standardserie" dropdown wrote a separate field the engine ignored, and cash-method invoice payments (invoice_cash_payment) weren't exposed in settings — so configured series were silently dropped to "A". - Expose cash/private payment source types in the per-source-type form - Write the global default through to the map on save, keeping overrides - Resolve voucher-sequences/next by source_type (+date) to match the engine - Show the upcoming voucher (V2) in the payment dialog title - Share resolveInvoicePaymentSourceType so preview and booking can't drift Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(salary): keep AGI panel in sync with Skatteverket signing state The AGI panel mixed run-scoped generation state (agi_generated_at, agi_declarations) with period-scoped submission state (extension_data agi_submission_{period}), so the two could drift and present contradictory UI. Reconcile them: - Auto-detect a Mina Sidor BankID signature: while awaiting_signing, poll /agi/kvittenser on mount and on tab refocus so the panel flips to "signed" (hiding the signing actions) without a manual "Hamta kvittens" click. - Warn instead of offering to sign when the locked granskningsunderlag predates the run's latest AGI generation (draftIsStale) — avoids filing superseded figures. - Self-heal a stale "AGI-XML saknas" error once the run's AGI is (re)generated out-of-band (MCP/API/other tab). - Refetch the salary run on tab focus so agi_generated_at reflects out-of-band generation without a hard reload. - /agi/lasUpp now clears the cached agi_submission_{period} record, so unlocking drops the panel back to the pre-submission state instead of stranding it on a released "redo att signeras" draft. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: Implement VAT registration handling and invoice item line types - Added VAT registration check in commitCreateInvoice to set VAT rate to 0% for non-VAT registered companies. - Updated invoice creation logic to reflect 'exempt' VAT treatment and adjusted related fields accordingly. - Introduced support for free-text and blank spacer rows in invoice items by adding a new line_type field. - Enhanced invoice and credit note handling to accommodate new line types. - Added new localized messages for text rows in English and Swedish. - Created tests for salary run approval logic, ensuring bank details are validated correctly. - Implemented effective net payout calculation for salary runs, considering tax overrides. - Added SQL migrations to support new invoice item line types and accounting method awareness for linking invoices to vouchers. * feat(articles): artikelregister with revenue account + VAT rate per article Article register (non-inventory) with per-article VAT rate and optional BAS class-3 revenue-account override. Includes API routes, UI pages, MCP tools, pending-operation staging, and the activate-or-create account flow (ACCOUNTS_NOT_IN_CHART -> ActivateAccountsDialog, unknown numbers -> AddAccountDialog) reusing the journal entry UX. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(bookkeeping): no-doc-required batch + bulk-missing endpoints Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(payments): supplier payment lines + cash-method invoice matching Shared payment-line proposal for supplier invoices, improved match-invoice/match-supplier-invoice flows (kontantmetoden-aware), and voucher-link support without requiring a 151x clearing entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(bookkeeping): new journal entry dialog, SIE import tweaks, misc New journal entry dialog component, journal list/page updates, invoice editor updates, SIE import adjustments, transaction ingest and api-key tweaks, pr-agent workflow update. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(invoices): implement tax reduction features and localization updates * feat(tests): add VAT registration gate to pending operations commit tests --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
185 lines
5.9 KiB
TypeScript
185 lines
5.9 KiB
TypeScript
/**
|
|
* Unit tests for the create_invoice executor, run through the public
|
|
* `commitPendingOperation` dispatcher (executors are not exported).
|
|
*
|
|
* Covers the two server-authoritative VAT behaviors flagged in review:
|
|
* 1. A non-VAT-registered company gets every line rate coerced to 0 and the
|
|
* invoice stored as momsfri ('exempt'), regardless of what was staged.
|
|
* 2. Free-text rows (line_type 'text') are excluded from subtotal, VAT, and
|
|
* mixed-rate detection — a text row's 0% must not flip vat_rate to null.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import { makeCustomer } from '@/tests/helpers'
|
|
import type { PendingOperation } from '@/types'
|
|
|
|
import { commitPendingOperation } from '../commit'
|
|
|
|
function makePendingOp(overrides: Partial<PendingOperation>): PendingOperation {
|
|
return {
|
|
id: 'op-1',
|
|
user_id: 'user-1',
|
|
company_id: 'company-1',
|
|
operation_type: 'create_invoice',
|
|
status: 'pending',
|
|
title: 'test',
|
|
params: {},
|
|
preview_data: {},
|
|
result_data: null,
|
|
actor_type: 'user',
|
|
actor_id: null,
|
|
actor_label: null,
|
|
risk_level: 'medium',
|
|
created_at: '2026-05-03T00:00:00Z',
|
|
resolved_at: null,
|
|
updated_at: '2026-05-03T00:00:00Z',
|
|
...overrides,
|
|
} as PendingOperation
|
|
}
|
|
|
|
/**
|
|
* Queue-based supabase mock that also records `.insert()` payloads per table,
|
|
* so assertions can inspect what was actually written.
|
|
*/
|
|
function createCapturingSupabase(results: Array<{ data?: unknown; error?: unknown }>) {
|
|
const queue = [...results]
|
|
const inserts: Record<string, unknown[]> = {}
|
|
|
|
const from = vi.fn((table: string) => {
|
|
const raw = queue.shift() ?? { data: null, error: null }
|
|
const result = { data: raw.data ?? null, error: raw.error ?? null }
|
|
const chain: object = new Proxy(
|
|
{},
|
|
{
|
|
get(_target, prop) {
|
|
if (prop === 'then') {
|
|
return (resolve: (v: unknown) => void) => resolve(result)
|
|
}
|
|
if (prop === 'insert') {
|
|
return (payload: unknown) => {
|
|
;(inserts[table] ??= []).push(payload)
|
|
return chain
|
|
}
|
|
}
|
|
return () => chain
|
|
},
|
|
},
|
|
)
|
|
return chain
|
|
})
|
|
|
|
return { supabase: { from }, inserts }
|
|
}
|
|
|
|
const customer = makeCustomer({ id: 'cust-1', customer_type: 'swedish_business' })
|
|
|
|
/** Queue for the dispatcher + executor call sequence (SEK, no overrides):
|
|
* CAS claim → customers → company_settings → invoices insert →
|
|
* invoice_items insert → complete-invoice select → dispatcher update. */
|
|
function queueFor(settings: { vat_registered: boolean } | null) {
|
|
return [
|
|
{ data: { id: 'op-1' } },
|
|
{ data: customer },
|
|
{ data: settings },
|
|
{ data: { id: 'inv-1', invoice_number: null } },
|
|
{ data: null },
|
|
{ data: { id: 'inv-1' } },
|
|
{ data: null },
|
|
]
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
eventBus.clear()
|
|
})
|
|
|
|
describe('commitPendingOperation: create_invoice', () => {
|
|
it('coerces a staged non-zero VAT rate to 0 for a non-VAT-registered company', async () => {
|
|
const { supabase, inserts } = createCapturingSupabase(queueFor({ vat_registered: false }))
|
|
|
|
const op = makePendingOp({
|
|
params: {
|
|
customer_id: 'cust-1',
|
|
items: [{ description: 'Konsulttimmar', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
|
|
invoice_date: '2026-06-01',
|
|
due_date: '2026-07-01',
|
|
},
|
|
})
|
|
|
|
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
|
|
|
expect(result.status).toBe('committed')
|
|
expect(inserts['invoices']).toHaveLength(1)
|
|
expect(inserts['invoices'][0]).toMatchObject({
|
|
subtotal: 1000,
|
|
vat_amount: 0,
|
|
total: 1000,
|
|
vat_rate: 0,
|
|
vat_treatment: 'exempt',
|
|
moms_ruta: null,
|
|
})
|
|
const itemRows = inserts['invoice_items'][0] as Array<Record<string, unknown>>
|
|
expect(itemRows).toHaveLength(1)
|
|
expect(itemRows[0]).toMatchObject({ vat_rate: 0, vat_amount: 0 })
|
|
})
|
|
|
|
it('keeps the staged rate for a VAT-registered company', async () => {
|
|
const { supabase, inserts } = createCapturingSupabase(queueFor({ vat_registered: true }))
|
|
|
|
const op = makePendingOp({
|
|
params: {
|
|
customer_id: 'cust-1',
|
|
items: [{ description: 'Konsulttimmar', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
|
|
},
|
|
})
|
|
|
|
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
|
|
|
expect(result.status).toBe('committed')
|
|
expect(inserts['invoices'][0]).toMatchObject({
|
|
subtotal: 1000,
|
|
vat_amount: 250,
|
|
total: 1250,
|
|
vat_rate: 25,
|
|
moms_ruta: '05',
|
|
})
|
|
})
|
|
|
|
it('excludes text rows from totals and mixed-rate detection', async () => {
|
|
const { supabase, inserts } = createCapturingSupabase(queueFor({ vat_registered: true }))
|
|
|
|
const op = makePendingOp({
|
|
params: {
|
|
customer_id: 'cust-1',
|
|
items: [
|
|
{ description: 'Konsulttimmar', quantity: 2, unit: 'tim', unit_price: 500, vat_rate: 25 },
|
|
{ line_type: 'text', description: 'Avser vecka 23', quantity: 0, unit: '', unit_price: 0, vat_rate: 0 },
|
|
],
|
|
},
|
|
})
|
|
|
|
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
|
|
|
expect(result.status).toBe('committed')
|
|
// The text row's 0% must not trigger mixed-rate (vat_rate: null).
|
|
expect(inserts['invoices'][0]).toMatchObject({
|
|
subtotal: 1000,
|
|
vat_amount: 250,
|
|
total: 1250,
|
|
vat_rate: 25,
|
|
})
|
|
const itemRows = inserts['invoice_items'][0] as Array<Record<string, unknown>>
|
|
expect(itemRows).toHaveLength(2)
|
|
expect(itemRows[0]).toMatchObject({ line_type: 'product', vat_rate: 25, vat_amount: 250, line_total: 1000 })
|
|
expect(itemRows[1]).toMatchObject({
|
|
line_type: 'text',
|
|
description: 'Avser vecka 23',
|
|
quantity: 0,
|
|
unit_price: 0,
|
|
line_total: 0,
|
|
vat_rate: 0,
|
|
vat_amount: 0,
|
|
})
|
|
})
|
|
})
|