16fbcefbbc
* feat(invariants): centralise shared format contracts, reconcile the org-number paths
The same format rules were written out independently across the codebase, and
where they disagreed the disagreement was invisible until a filing failed.
Worst case, now fixed: four Skatteverket- and Bolagsverket-bound export paths
each had their own idea of a valid organisationsnummer.
lib/skatteverket/format.ts strip '-' only threw on any input with a space
lib/salary/ku/ku10-generator.ts replace('-', '') first hyphen only, spaces survived
lib/salary/agi/xml-generator.ts strip non-digits stray letters passed the length check
lib/bokslut/ixbrl/validate /^\d{6}-?\d{4}$/ rejected the 12-digit form, no Luhn
A company stored with a space or in 12-digit form could file AGI all year and
then fail at the arsredovisning deadline with a message that did not say why.
lib/invariants/ now owns account number, ISO date, four-digit fiscal year and
org number, each with the rationale recorded next to the rule. normalizeOrgNumber
moves here from lib/company-lookup/ and isSaneDateString from lib/utils.ts; both
old paths re-export, so no caller changes. lib/api/schemas.ts builds its
primitives on the module, so ~100 schemas inherit any correction.
The arsredovisning check-digit verdict is a warn, not an error: a wrong Luhn
digit is almost certainly a typo worth surfacing, but whether every org number
Bolagsverket accepts satisfies Luhn is a Swedish domain question we have not
verified against a primary source, and an error there blocks Skicka in. We do
not block a statutory filing on an unverified assumption.
KU10 still passes a 12-digit stored org number through unfolded. That is
pre-existing, and whether the KU10 schema wants 10 or 12 digits is not covered
by the swedish-payroll skill, so it is pinned by a test rather than changed
silently.
Guard 8 (hand-rolled-invariant) tracks the remaining 114 inline copies as a
ratchet that may only go down, same mechanism as the roundOre guard.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* test(ci): add an upgrade-path job that applies new migrations against real data
The pg-real job applies all 548 migrations to an EMPTY database. Empty means
zero rows, so a migration that adds a NOT NULL, adds a CHECK, creates a unique
index or backfills passes trivially in CI and can still fail on production,
where the rows exist. CI proved that a fresh install works; nothing proved that
an existing install upgrades.
The new pg-upgrade job: apply the schema as it stands at the merge base, seed a
small real company (three posted verifikat, balanced lines, one ore-level
amount), then apply ONLY the migrations this PR adds, then assert the data
survived (entries still posted, lines intact, ledger still balances, ore
unchanged, voucher numbers sequential). A PR with no migration no-ops.
Verified locally against supabase/postgres:15.8.1.060 rather than assumed, with
three deliberately bad migrations:
rescale money on posted lines empty: would pass seeded: ERROR (immutability trigger)
CHECK violating the ore row empty: exit 0 seeded: exit 3
NOT NULL on a populated column empty: exit 0 seeded: exit 3
Base migrations are read out of the merge-base git tree, not the working tree,
so a PR that edits an already-shipped migration still gets the original applied
and the edit surfaces as a failure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* docs: record the invariants and upgrade-CI decisions
Two entries covering what this PR changes and, more importantly, the calls that
are not obvious from the diff: why the arsredovisning check-digit verdict is a
warning rather than an error, why KU10's 12-digit passthrough is pinned instead
of fixed, and why the ROT/RUT brf org-number schemas stay on their own rule.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* docs(test): mark the upgrade fixture as CI-only, never a production template
The fixture writes posted journal_entries and their lines directly, bypassing
the engine and the atomic commit RPC. That is the only way to hand a migration
pre-existing posted rows to break, and it is safe against a throwaway CI
database, but it reads like a sanctioned pattern to anyone who finds it later.
Says so explicitly, with the reason it is confined here (no voucher sequence to
keep gapless, no retention obligation on a database destroyed with the job) and
a pointer back to Hard Rule 2 for anything touching a real database.
Raised by the Swedish compliance review bot on #1364.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
86 lines
3.3 KiB
SQL
86 lines
3.3 KiB
SQL
-- Upgrade-path assertions: run AFTER the pull request's migrations have been
|
|
-- applied on top of the seeded database.
|
|
--
|
|
-- Every check raises an exception on failure, so `psql -v ON_ERROR_STOP=1`
|
|
-- fails the job. Keep the assertions about invariants that must hold for ANY
|
|
-- migration, not about the specifics of one change.
|
|
|
|
DO $$
|
|
DECLARE
|
|
v_entries INT;
|
|
v_lines INT;
|
|
v_debits NUMERIC;
|
|
v_credits NUMERIC;
|
|
v_ore NUMERIC;
|
|
v_company INT;
|
|
v_period INT;
|
|
v_max_voucher INT;
|
|
BEGIN
|
|
-- 1. The company, its membership and its fiscal period survived.
|
|
SELECT count(*) INTO v_company
|
|
FROM public.companies WHERE id = '22222222-2222-2222-2222-222222222222';
|
|
IF v_company <> 1 THEN
|
|
RAISE EXCEPTION 'upgrade: seeded company disappeared (found %)', v_company;
|
|
END IF;
|
|
|
|
SELECT count(*) INTO v_period
|
|
FROM public.fiscal_periods WHERE id = '33333333-3333-3333-3333-333333333333';
|
|
IF v_period <> 1 THEN
|
|
RAISE EXCEPTION 'upgrade: seeded fiscal period disappeared (found %)', v_period;
|
|
END IF;
|
|
|
|
-- 2. All three posted verifikat survived, still posted. A migration must
|
|
-- never silently drop or unpost a posted entry (BFL 5 kap).
|
|
SELECT count(*) INTO v_entries
|
|
FROM public.journal_entries
|
|
WHERE company_id = '22222222-2222-2222-2222-222222222222'
|
|
AND status = 'posted';
|
|
IF v_entries <> 3 THEN
|
|
RAISE EXCEPTION 'upgrade: expected 3 posted entries after migration, found %', v_entries;
|
|
END IF;
|
|
|
|
-- 3. Every line survived.
|
|
SELECT count(*) INTO v_lines
|
|
FROM public.journal_entry_lines l
|
|
JOIN public.journal_entries e ON e.id = l.journal_entry_id
|
|
WHERE e.company_id = '22222222-2222-2222-2222-222222222222';
|
|
IF v_lines <> 7 THEN
|
|
RAISE EXCEPTION 'upgrade: expected 7 journal entry lines after migration, found %', v_lines;
|
|
END IF;
|
|
|
|
-- 4. The ledger still balances. This is the assertion that catches a
|
|
-- migration which retypes, rescales or rounds a money column.
|
|
SELECT COALESCE(sum(l.debit_amount), 0), COALESCE(sum(l.credit_amount), 0)
|
|
INTO v_debits, v_credits
|
|
FROM public.journal_entry_lines l
|
|
JOIN public.journal_entries e ON e.id = l.journal_entry_id
|
|
WHERE e.company_id = '22222222-2222-2222-2222-222222222222';
|
|
IF v_debits <> v_credits THEN
|
|
RAISE EXCEPTION 'upgrade: ledger no longer balances after migration (debits %, credits %)',
|
|
v_debits, v_credits;
|
|
END IF;
|
|
IF v_debits <> 20623.45 THEN
|
|
RAISE EXCEPTION 'upgrade: total debits changed from 20623.45 to %', v_debits;
|
|
END IF;
|
|
|
|
-- 5. The öre survived exactly. Money is NUMERIC and must not drift.
|
|
SELECT l.debit_amount INTO v_ore
|
|
FROM public.journal_entry_lines l
|
|
WHERE l.journal_entry_id = '44444444-4444-4444-4444-444444444403'
|
|
AND l.account_number = '6570';
|
|
IF v_ore IS DISTINCT FROM 123.45 THEN
|
|
RAISE EXCEPTION 'upgrade: öre-level amount drifted from 123.45 to %', v_ore;
|
|
END IF;
|
|
|
|
-- 6. Voucher numbers are intact and still sequential from 1.
|
|
SELECT max(voucher_number) INTO v_max_voucher
|
|
FROM public.journal_entries
|
|
WHERE company_id = '22222222-2222-2222-2222-222222222222';
|
|
IF v_max_voucher <> 3 THEN
|
|
RAISE EXCEPTION 'upgrade: highest voucher number changed to %, expected 3', v_max_voucher;
|
|
END IF;
|
|
|
|
RAISE NOTICE 'upgrade-path assertions passed: % entries, % lines, balanced at %',
|
|
v_entries, v_lines, v_debits;
|
|
END $$;
|