* fix(security): gate replace_sie_import behind owner/admin membership The RPC was SECURITY DEFINER with EXECUTE granted to PUBLIC and anon, no company_members lookup, no auth.uid() reference and no unauthorized raise, while setting gnubok.allow_delete to disarm the BFL immutability and retention triggers. Any caller holding a company_id and an import id could hard delete another tenant's verifikationer. Confirmed live in production. Applies the same fail closed owner/admin guard that undo_sie_import already carries (migration 20260624120000), resolving the actor from COALESCE(p_user_id, auth.uid()) so it denies when the role is NULL, then revokes EXECUTE from PUBLIC and anon. search_path and the raised statement_timeout are restated, since CREATE OR REPLACE drops settings that are not repeated. userId is a required parameter on replaceSIEImport: the service client has a NULL auth.uid(), so a caller without an explicit actor now fails to compile rather than hitting the closed gate at runtime. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(security): validate arcim OAuth callback state server side The callback route is skipAuth and decoded the state parameter as plain base64url JSON, trusting consentId and provider from it. A one time code was minted at flow start and never read. An unauthenticated attacker who learned a consent id could run an OAuth flow on their own provider account and post the callback with a forged state, landing their tokens on another tenant's consent, so the victim's next migration imported the attacker's ledger. State is now an opaque randomBytes(32) pointer to a provider_otc row, consumed by a single atomic UPDATE guarded on used_at IS NULL and expires_at, so a replay loses the row lock race and updates nothing. provider is read from provider_consents rather than trusted from the client. provider_otc already existed for exactly this purpose and was never wired up. Also scopes getConsent to an owning company, closing a cross tenant status oracle where the preview and migrate paths echoed a consent's status before the scoped check ran. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(security): scope documents storage to company_id (phase A) The documents bucket policies matched on auth.uid(), and upload keys were documents/{userId}/..., so company membership was never consulted. Removing a member revoked nothing: their session still authenticated and they kept direct Storage read access to every receipt, supplier invoice and bank statement they had uploaded. The same bug was fixed for sie-files in 20260416120000; this bucket was left behind. Phase A is additive. Company scoped policies are added alongside the uploader scoped ones, uploads move to documents/{companyId}/{userId}/..., and reads accept either layout so nothing breaks mid migration. Phase C, which drops the old policies, is gated on the backfill reporting zero remaining legacy prefix objects. The policy compares the company segment as text rather than casting to uuid the way sie-files does: this bucket holds keys whose second segment is not a uuid (MCP audit packages), and Postgres does not guarantee the bucket prefix qual runs before the cast, so a planner reordering would raise 22P02 and fail the whole query instead of filtering the row out. deleteDocument now removes both candidate keys. Removing only the stored pointer would leave a readable orphan copy of a document the user asked to erase. The backfill script is included but has never been run. It defaults to dry run, refuses .env.local by name, and verifies each copy is readable and SHA-256 identical before repointing the row. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(security): enforce events:read scope and membership on /api/events This was the only one of the three validateApiKey call sites with no downstream guard: v1 and the MCP server both check scope and re-verify company membership, this route did neither. An events:read scope existed and was documented as gating the endpoint but was never called, so a legacy key falling back to DEFAULT_SCOPES read the full log. The bound company id went straight from the api_keys row into a service role query, so a key whose user had been removed from the company kept reading. Adds the scope check before any database access, re-verifies company_members with archived_at IS NULL, honours test mode by stamping X-Gnubok-Mode instead of ignoring it, applies minimisePayload so the pull surface can never return a wider payload than the push surface, and replaces the three flat error strings with the canonical envelope. Test key reads are served rather than blocked: TEST_KEY_WRITE_BLOCKED is gated on mutations in with-api-v1, so a read gets the same treatment as every other v1 read endpoint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * perf(bookkeeping): sweep remaining journal_entries!inner embeds A previous refactor removed this pattern from lib/reports and introduced fetchEntryLines, but the class was never swept. Seventeen sites remained and had become the top application consumer of production database time: measured across the resulting query shapes, 32,694 calls and 25,848 seconds of execution, mean 790ms, with shapes averaging 2.6s and 3.0s and maxing at 7,962ms against the 8s statement_timeout, which surfaced to users as 500s on the booking path. PostgREST compiles an embed with filters on the embedded side into a correlated INNER JOIN LATERAL with a parameterized LIMIT, which stops Postgres reordering the join, so each query walked the whole journal_entry_lines table across all tenants. Driving from the entries side instead turns that into two indexed round trips. Converted sites keep their existing shape: the helper reattaches the parent entry under the same key the embed produced. Several conversions also remove a latent silent truncation where an unpaginated query was capped at PostgREST's 1000 row ceiling. Two deliberate exceptions. The free text ilike legs of the MCP display query stay on the embed, because each is capped at legLimit and that cap drives the truncation contract the tool reports, while the helper is unbounded. The accounts route moves to the existing get_account_usage_counts RPC instead, since its embed was a head count and the helper returns rows. commitEntry's write path is untouched: the change there is confined to the read query of the pre-commit dimension rule check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(api): anchor v1 list cursors on created_at Page two returned page one, forever, while still advertising a fresh next_cursor. The three routes sorted by and encoded a Postgres date column, which serializes as YYYY-MM-DD, but decodeDefaultCursor validates the cursor timestamp as full ISO-8601 and returned null, so the keyset filter was never applied and has_more never went false. An integrator syncing verifikat looped on the newest rows indefinitely. The transactions route already solved this and its comment names the trap; the fix was never ported. All three now order and encode on created_at with an id tie break, matching the transactions keyset predicate exactly. ISO_TIMESTAMP is deliberately left alone: relaxing it would silently change sort semantics on the route that currently works. Default ordering therefore moves from business date to insert order. Every business date is still on the row, and the invoices list gains date_from and date_to filters so a date range is still reachable; the other two already had them. The tests use an in-memory PostgREST that actually evaluates the filters, because the repo's pass-through mock cannot catch this class of bug: the bug is that the filter is never sent. They walk to exhaustion with a hard iteration cap, so an unterminated walk fails instead of hanging. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(api): separate dry run from commit in the idempotency hash The request hash was built from url.pathname, which excludes the query string, so a dry run and its commit hashed identically. Following the flow documented in dry-run.ts, re-issuing the request with the same Idempotency-Key returned the cached preview with Idempotent-Replayed set and wrote nothing, while reporting 200. An agent or integrator saw success for a write that never happened. dry_run is folded into the hash only when true, not as an unconditional boolean. Including it as false would change the hash of every ordinary write, and with a 24h idempotency TTL any key in flight across the deploy would fail the request_hash comparison and 409 on a legitimate retry. Both hash call sites now go through one shared helper so they cannot drift into a permanent cache miss, and dry run responses are no longer stored at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * ci: install the Bedrock SDK out of tree in the compliance review The Swedish accounting compliance gate had failed ten consecutive runs and so was posting nothing. With --no-package-lock npm discarded the lockfile and re-resolved the whole tree from package.json, floating @hookform/resolvers to 5.4.3, whose valibot ^1 peer conflicts with the pinned valibot 0.39.0. Installing into the parent of the checkout resolves only that one package, so an unrelated peer conflict can never take the gate down again. Node still finds it because ESM bare specifiers walk up parent node_modules; NODE_PATH would not have worked, as it is CommonJS only. --legacy-peer-deps was rejected because it masks future genuine peer conflicts and still reifies the full tree. The same step's SDK version is aligned from 0.31.0 back to the 0.29.1 that package.json and check:guards enforce after the streaming outage. That drift went unnoticed because the pin guard only inspects package.json and the lockfile, never workflow files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * build(docker): generate crontabs from vercel.json vercel.json defines 16 cron jobs; both Docker crontabs carried 9, and were byte identical to each other. Self hosted deployments therefore never sent recurring invoices, never dispatched webhooks and never cleaned up idempotency keys. tax-deadlines also ran once a year on 2 January instead of daily, and documents/verify weekly instead of daily. Extension crons are included rather than excluded. The Dockerfile copies the whole tree before building, so every extension cron route is compiled into the image regardless of the enabled preset, and each returns 200 when its extension is unconfigured, so curl -sf logs no failure. Two such entries were already present in the crontab for extensions absent from the preset, which settles the intent. documents/verify is treated as drift rather than a self hosted concession: the weekly cadence was present in the hosted crontab too, and the run is capped at 200 documents walking a nulls-first queue, so weekly drains the integrity queue seven times slower on a check that exists for BFL retention. webhooks/dispatch keeps its per minute cadence, adding 1,440 requests a day on self hosted. A gentler tick would silently stretch the first retry, since the retry ladder opens at 60 seconds. SCHEDULE_OVERRIDES is the one line place to change that. A parity test asserts the path sets match minus a documented exclusion list, and ratchets three cron routes that are currently scheduled nowhere so they are named rather than silently rotting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(observability): add a provider agnostic error sink There is no error tracking in this codebase: logs go to console and Vercel retention and nowhere else, nothing alerts on the 16 cron jobs, and seven code comments across lib, app, components and extensions asserted that Sentry captures errors when Sentry is not a dependency. The two most recent bug fixes on this repo were both discovered by customer email. This adds the sink, not a vendor. No dependency is taken: the interface has a no-op default and a registration point, so behaviour is unchanged until an adapter is registered. Releases are tagged from the build id already inlined by next.config.ts. Redaction moved out of lib/logger.ts into a leaf module that both the logger and the sink import, so there is one denylist and no path from application data to a third party can skip the personnummer regex, including direct sink calls that bypass the logger. That matters here because these logs carry personnummer and financial data. verifyCronSecret now reports its own 401s, which covers all 16 jobs without touching a route file and catches the case where CRON_SECRET is rotated without updating the scheduler and every job silently 401s forever. The threshold is one failure rather than the backup alert's three: suppressing the first occurrence is precisely how an outage stays invisible. The seven misleading comments are corrected to describe what the code actually does, including the two cases that still are not covered: the client side one, since the sink is server side, and a warn level call that is not forwarded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix: remediate the 2026-07-26 similar-sweep findings across all surfaces Resolves the ~150-finding sweep (dev_docs/similar-sweep-2026-07-26.md) with one agent per finding; every behavioural fix carries a regression test proven to fail at HEAD. Full status, corrections to the sweep, refusals and open decisions in dev_docs/similar-sweep-2026-07-26-remediation-status.md. Structural roots closed: - resolveSekAmountOrNull(): honest SEK resolution refuses instead of booking 1:1; four duplicated toSek closures now refuse via INVOICE_FX_RATE_MISSING - ledger-line-amount.ts: journal_entry_lines.currency labels the document, not the amount; SQL pre-filter decoy proven and fixed - sparse-patch.ts: .partial() does not strip .default() in Zod 4.4.3; the exploitable salary payslip-line PATCH and KPI preferences sinks fixed - tests/schema: migration-replay phantom-column guard (13k+ refs, closed CHECK sets, onConflict targets); found 28 real defects, all fixed, all four baselines now empty - three new ratchet guards: sek-labelled-amount, cross-extension-import, ungated-extension-route Highlights: lawful VAT-rate set on all seven invoice surfaces (ML 6 kap), RC input VAT mismatch wired on web + both MCP callers, missing-underlag resource delegates to the shared RPC predicate, push-notifications consent polarity fail-closed, deadlines undo honours requested state, silent-failure and read-side-fabrication classes fixed across settings/KPI/inbox/Stripe/ Arcim/kassaflodesanalys, error-envelope stringification fixed at 10+ sites with isSwedishUserMessage extended. Also includes the parallel session's MCP invoice tools (update_invoice, recurring schedules, invoice deliveries) which share files with the sweep work and are verified green together. 13 new migrations are NOT applied anywhere; they apply via branch merge. 20260726120000 backfills 1247 supplier-invoice rows. pg tests for new DDL are written but unrun (no local Postgres). Verified: 11088 tests / 881 files green, tsc 0 non-test errors, lint 0 errors, check:guards passing, MCP payload 57475/57500. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(migrations): rename replace_sie_import migration off main's 20260726090000 version origin/main shipped 20260726090000_agent_quota_rpc_caller_guard.sql; keeping our replace_sie_import migration on the same version would abort the Supabase apply with a schema_migrations_pkey duplicate at merge time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(review): remediate pre-publish deep-review findings across all slices A 13-agent review of the full branch diff surfaced 1 critical, 5 high and ~45 further findings; this commit resolves them in one pass: - replace_sie_import / undo_sie_import: p_user_id honored only for service_role callers; any other caller is pinned to auth.uid() (impersonation gate bypass), authz raise errcode 42501 mapped to a Swedish 403 in the route, new caller-guard migration for undo - bulk_book_transactions refuses homogeneous non-SEK batches instead of writing foreign magnitudes into SEK ledger columns - credit-note cap trigger: company-match on credited_invoice_id, no cross-tenant figures in exception text - link_voucher RPCs resolve NULL invoice currency as SEK end to end - personal-number ciphertext CHECK split into NOT VALID + VALIDATE - same-currency foreign settlements clear 1510 at booking rate and book realized diff to 3960/7960; rate-less foreign write paths refuse - receivables revaluation covers partially_paid and outstanding amounts - period lock guard paginates candidates past the PostgREST 1000 cap - documents: service-client storage removals after authz, dual-layout reads in integrity cron and archive export, backfill delete-source sweep actually deletes with hash verification and shared-key grouping - invoice matching normalizes NULL/lowercase currencies (regression), duplicate candidates stop claiming amount matches they never ran - match-invoice aborts on any booking failure (no paid-without-verifikat) - refresh-exchange-rate reverts on concurrent booking (TOCTOU window) - KPI preferences upsert arbiter aligned to the company-scoped constraint - personnummer_last4 stripped from all salary responses incl. MCP tools - worked-hours batch restores destroyed rows on conflict and error paths - MCP: shared duplicate-claim builder (no more 'null kr'), short-circuit on tag_journal_lines overflow, auto_send schedules stage as high risk - observability sink redacts emails/IBANs/API keys and keeps redacted stacks in prod; assorted small guards (safe-return-to /@, dry_run=True, cursor helper off-by-one, OAuth state TTL 10 min, arcim saveMappings call removed) Full dispositions, deferred items and hand-verified accounting numbers are documented in the PR body and DECISIONS.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(personnummer): implement masking and encryption for personal numbers with tests * fix(review): address CI and compliance-bot findings for PR #1215 pg-real: the CI image's auth shim reads the legacy request.jwt.claim.role GUC, so both service-role simulations (runAsServiceRole and the invoice-delivery test's local helper) never satisfied auth.role() = 'service_role' and every legitimate p_user_id path failed closed; the shared helper now sets both GUC shapes plus SET LOCAL ROLE with a fail-loud sanity check, and the delivery test reuses it. The link-voucher migration had recreated both RPCs from pre-rewrite file text, reintroducing the NULL-unsafe membership pattern the null-safe-tenant-guards ratchet bans; both guards now use public.caller_is_company_member() with all currency changes preserved. Compliance bots: the customers export now emits the standard masked form instead of raw AES-256-GCM ciphertext in the Org-/personnummer column, and maskCustomerRow returns a non-round-trippable placeholder on decrypt failure instead of 500ing the list. MCP parity: gnubok_lock_period's staging pre-check now runs the exact countUnbookedInPeriod the commit path enforces (exported from period-service; local mirror deleted), and gnubok_agi_status resolves AGI state run-scoped so a correction run no longer renders as already filed. Declined with evidence: PR-Agent's opening-balances null-zeroing concern (all mergeable columns are NOT NULL with defaults per 20260713101000). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(review): address codex review findings on PR #1215 - restore 20260726140000 to its preview-recorded content and restate the NULL-safe tenant guard under 20260727130000: a recorded migration version never re-runs, so the in-place edit could not reach the preview branch - replace toFixed() with sv-SE two-decimal formatting in the ROT/RUT cap warning texts and update the pinned test expectations - drop the em dash in the fiscal-periods route comment - strip trailing whitespace in import-existing.test.ts Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(reports): raise timeout on real PDF render tests renderToBuffer does real @react-pdf layout work and exceeds the 5s default when the full suite saturates the CPU; tests pass in isolation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2265 lines
98 KiB
TypeScript
2265 lines
98 KiB
TypeScript
/**
|
|
* Tests for the generic transaction ingestion pipeline.
|
|
*
|
|
* Covers deduplication, insert, invoice matching, auto-categorization,
|
|
* and result aggregation.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { ingestTransactions, type RawTransaction } from '../ingest'
|
|
import { makeJournalEntry, makeTransaction } from '@/tests/helpers'
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Mocks
|
|
// ---------------------------------------------------------------------------
|
|
|
|
const mockEvaluateMappingRules = vi.fn()
|
|
vi.mock('@/lib/bookkeeping/mapping-engine', () => ({
|
|
evaluateMappingRules: (...args: unknown[]) => mockEvaluateMappingRules(...args),
|
|
}))
|
|
|
|
const mockCreateTransactionJournalEntry = vi.fn()
|
|
vi.mock('@/lib/bookkeeping/transaction-entries', () => ({
|
|
createTransactionJournalEntry: (...args: unknown[]) =>
|
|
mockCreateTransactionJournalEntry(...args),
|
|
}))
|
|
|
|
const mockGetBestInvoiceMatch = vi.fn()
|
|
vi.mock('@/lib/invoices/invoice-matching', () => ({
|
|
getBestInvoiceMatch: (...args: unknown[]) => mockGetBestInvoiceMatch(...args),
|
|
}))
|
|
|
|
const mockFetchExchangeRate = vi.fn()
|
|
vi.mock('@/lib/currency/riksbanken', () => ({
|
|
fetchExchangeRate: (...args: unknown[]) => mockFetchExchangeRate(...args),
|
|
}))
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Queue-based Supabase mock
|
|
// ---------------------------------------------------------------------------
|
|
|
|
function createQueueMockSupabase() {
|
|
const resultQueue: { data: unknown; error: unknown }[] = []
|
|
// Captures .insert() payloads keyed by table, so tests can assert what was
|
|
// written (e.g. cash_account_id stamping).
|
|
const inserts: Record<string, unknown[]> = {}
|
|
// Same for .update() payloads (e.g. supplier-invoice suggestion linking).
|
|
const updates: Record<string, unknown[]> = {}
|
|
|
|
/**
|
|
* Push one or more results onto the queue.
|
|
* Each awaited Supabase chain pops the next result in FIFO order.
|
|
*/
|
|
const enqueue = (...results: { data?: unknown; error?: unknown }[]) => {
|
|
for (const r of results) {
|
|
resultQueue.push({ data: r.data ?? null, error: r.error ?? null })
|
|
}
|
|
}
|
|
|
|
const buildChain = (table: string): unknown => {
|
|
const handler: ProxyHandler<object> = {
|
|
get(_target, prop) {
|
|
if (prop === 'then') {
|
|
const next = resultQueue.shift() ?? { data: null, error: null }
|
|
return (resolve: (v: unknown) => void) => resolve(next)
|
|
}
|
|
if (prop === 'insert') {
|
|
return (payload: unknown) => {
|
|
;(inserts[table] ??= []).push(payload)
|
|
return buildChain(table)
|
|
}
|
|
}
|
|
if (prop === 'update') {
|
|
return (payload: unknown) => {
|
|
;(updates[table] ??= []).push(payload)
|
|
return buildChain(table)
|
|
}
|
|
}
|
|
return (..._args: unknown[]) => buildChain(table)
|
|
},
|
|
}
|
|
return new Proxy({}, handler)
|
|
}
|
|
|
|
const supabase = {
|
|
from: vi.fn().mockImplementation((table: string) => buildChain(table)),
|
|
rpc: vi.fn().mockImplementation(() => buildChain('rpc')),
|
|
}
|
|
|
|
return { supabase, enqueue, inserts, updates }
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Helpers
|
|
// ---------------------------------------------------------------------------
|
|
|
|
const USER_ID = 'user-1'
|
|
const COMPANY_ID = 'company-1'
|
|
|
|
function makeRaw(overrides: Partial<RawTransaction> = {}): RawTransaction {
|
|
return {
|
|
date: '2024-06-15',
|
|
description: 'Test transaction',
|
|
amount: -250.0,
|
|
currency: 'SEK',
|
|
external_id: `ext-${Math.random().toString(36).slice(2, 8)}`,
|
|
mcc_code: null,
|
|
merchant_name: null,
|
|
reference: null,
|
|
bank_connection_id: null,
|
|
import_source: 'test',
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
function makeMappingResult(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
rule: null,
|
|
debit_account: '5410',
|
|
credit_account: '1930',
|
|
risk_level: 'low',
|
|
confidence: 0.9,
|
|
requires_review: false,
|
|
default_private: false,
|
|
vat_lines: [],
|
|
description: 'Office supplies',
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Tests
|
|
//
|
|
// Queue order after batch dedup refactor:
|
|
// 1. Booked transaction map query
|
|
// 1b. Unbooked bank-synced transaction map query
|
|
// 2. Supplier invoices fetch
|
|
// 3. Batch external_id dedup query (returns matching external_ids)
|
|
// 4. Per-transaction: insert, updates, etc.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
describe('ingestTransactions', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 1. Successfully imports new transactions
|
|
// -----------------------------------------------------------------------
|
|
it('imports new transactions when no duplicate exists', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -100 })
|
|
const inserted = makeTransaction({ id: 'tx-1', external_id: raw.external_id })
|
|
|
|
// Booked transaction map query (no booked transactions)
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch (no unpaid invoices)
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert returns the new transaction
|
|
enqueue({ data: inserted, error: null })
|
|
// evaluateMappingRules will be called but we want low confidence
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.errors).toBe(0)
|
|
expect(result.transaction_ids).toEqual(['tx-1'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 1c. Stamps cash_account_id from the settlement account
|
|
// -----------------------------------------------------------------------
|
|
it('stamps cash_account_id on the insert when settlementAccount resolves', async () => {
|
|
const { supabase, enqueue, inserts } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -100 })
|
|
const inserted = makeTransaction({ id: 'tx-1', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'ca-1931' }, error: null }) // cash_accounts lookup
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(supabase.from).toHaveBeenCalledWith('cash_accounts')
|
|
const txInserts = inserts['transactions'] ?? []
|
|
expect(txInserts).toHaveLength(1)
|
|
expect((txInserts[0] as { cash_account_id?: string | null }).cash_account_id).toBe('ca-1931')
|
|
})
|
|
|
|
it('inserts cash_account_id null when no settlementAccount is given', async () => {
|
|
const { supabase, enqueue, inserts } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -100 })
|
|
const inserted = makeTransaction({ id: 'tx-1', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
// No cash_accounts lookup: settlementAccount omitted.
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(supabase.from).not.toHaveBeenCalledWith('cash_accounts')
|
|
const txInserts = inserts['transactions'] ?? []
|
|
expect((txInserts[0] as { cash_account_id?: string | null }).cash_account_id).toBeNull()
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2. Detects duplicates
|
|
// -----------------------------------------------------------------------
|
|
it('detects duplicates via external_id', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw()
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: returns matching external_id
|
|
enqueue({ data: [{ external_id: raw.external_id }], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
expect(result.transaction_ids).toEqual([])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2b. CSV row dedupes against uncategorized enable_banking row when
|
|
// date+amount+description prefix match (Lunar CSV vs Lunar PSD2 case).
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes CSV row against unbooked enable_banking row with matching description', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -250.0,
|
|
description: 'ICA Maxi Solna',
|
|
external_id: 'lunar_csvhash123',
|
|
import_source: 'csv_lunar',
|
|
})
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query: one PSD2 row with matching content
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250.0, description: 'ICA Maxi Solna' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: external_id differs, so no match
|
|
enqueue({ data: [], error: null })
|
|
// No insert expected: row should be deduplicated at content layer
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
expect(result.transaction_ids).toEqual([])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2b-edit. Edit-safety regression: a user-edited stored title must NOT
|
|
// reopen the duplicate-import window. The content bridge keys off the
|
|
// immutable original_description, so a re-import whose bank text still
|
|
// matches the original is deduped even though the stored (editable)
|
|
// description was changed.
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes against the original bank description even after the stored title was edited', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -250.0,
|
|
description: 'ICA Maxi Solna', // original bank text, re-imported via CSV
|
|
external_id: 'lunar_csvhash999', // different external_id → primary dedup misses
|
|
import_source: 'csv_lunar',
|
|
})
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced row whose TITLE was edited by the user, but whose
|
|
// original_description still holds the bank's verbatim text.
|
|
enqueue({
|
|
data: [
|
|
{
|
|
date: '2024-06-15',
|
|
amount: -250.0,
|
|
original_description: 'ICA Maxi Solna',
|
|
description: 'Mataffär (egen rubrik)',
|
|
},
|
|
],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: external_id differs, so no match
|
|
enqueue({ data: [], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2b-unknown. Legacy 'Unknown'/empty rows must still dedup: the stored-side
|
|
// content key is normalized the same way as the incoming side, so an
|
|
// existing row whose original_description is the legacy 'Unknown'
|
|
// sentinel matches an incoming 'Unknown' re-import (both → 'Okänd
|
|
// transaktion'). Without symmetric normalization this row would
|
|
// re-import as a duplicate.
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes legacy "Unknown" rows by normalizing both the stored and incoming keys', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -250.0,
|
|
description: 'Unknown', // legacy English sentinel re-imported via CSV
|
|
external_id: 'lunar_csvhashU',
|
|
import_source: 'csv_lunar',
|
|
})
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced row whose original_description is the legacy sentinel.
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250.0, original_description: 'Unknown', description: 'Unknown' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: external_id differs, so no match
|
|
enqueue({ data: [], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c. No false positive within ONE channel: same date+amount but a different
|
|
// description does NOT dedupe when the stored row is from the SAME feed
|
|
// (a re-import that legitimately holds two distinct same-(date,amount)
|
|
// transactions). Only a cross-channel mirror (2c-bis) drops the
|
|
// description requirement.
|
|
// -----------------------------------------------------------------------
|
|
it('does not dedupe a same-channel row when the description differs', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -250.0,
|
|
description: 'Coop Stockholm',
|
|
external_id: 'csv_lunar_456',
|
|
import_source: 'csv_lunar',
|
|
})
|
|
const inserted = makeTransaction({
|
|
id: 'tx-no-collision',
|
|
external_id: raw.external_id,
|
|
amount: -250.0,
|
|
})
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked row from the SAME feed (csv_lunar), same date/amount, DIFFERENT
|
|
// description → not a cross-channel mirror → must NOT dedupe.
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250.0, original_description: 'ICA Maxi Solna', description: 'ICA Maxi Solna', import_source: 'csv_lunar' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: no match
|
|
enqueue({ data: [], error: null })
|
|
// Insert succeeds: the new row is not a duplicate
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.transaction_ids).toEqual(['tx-no-collision'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-bis. Cross-channel mirror: the SAME bank account imported via two feeds
|
|
// (Nordea CSV payee text vs PSD2 OCR/message): same date+amount, one row
|
|
// per channel, descriptions that do NOT bridge: IS deduped on
|
|
// (date, öre). The real-world trigger: a CSV import landing on top of
|
|
// existing Enable Banking rows whose descriptions share no text.
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes a cross-channel mirror (CSV vs PSD2) even when descriptions do not bridge', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2025-10-23',
|
|
amount: -941,
|
|
description: 'Fortnox Finans AB', // Nordea CSV payee
|
|
external_id: 'nordea_business_abc123',
|
|
import_source: 'csv_nordea_business',
|
|
})
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Stored unbooked PSD2 row: same date+amount, DIFFERENT text (the OCR), from
|
|
// a DIFFERENT feed (enable_banking).
|
|
enqueue({
|
|
data: [{ date: '2025-10-23', amount: -941, original_description: '506401841738056', description: '506401841738056', import_source: 'enable_banking' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: different namespace, no match
|
|
enqueue({ data: [], error: null })
|
|
// No insert: deduped by the cross-channel mirror.
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-ter. Cross-channel but NOT a mirror (counts differ) → ambiguous, so the
|
|
// description requirement stands and nothing is dropped. Two incoming CSV
|
|
// rows + one stored PSD2 row with no bridging text → both incoming kept.
|
|
// Guards the rare case where the two feeds disagree on how many
|
|
// transactions a (date, öre) bucket holds: prefer a visible (deletable)
|
|
// duplicate over silently collapsing a genuinely-new row.
|
|
// -----------------------------------------------------------------------
|
|
it('does not text-independently dedupe an asymmetric cross-channel bucket', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const rows = [
|
|
makeRaw({ date: '2025-10-23', amount: -500, description: 'Betalning A', external_id: 'nordea_business_a', import_source: 'csv_nordea_business' }),
|
|
makeRaw({ date: '2025-10-23', amount: -500, description: 'Betalning B', external_id: 'nordea_business_b', import_source: 'csv_nordea_business' }),
|
|
]
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Only ONE stored PSD2 row (different text) → incoming 2 vs cross 1 = asymmetric.
|
|
enqueue({
|
|
data: [{ date: '2025-10-23', amount: -500, original_description: 'A107 RAMBER', description: 'A107 RAMBER', import_source: 'enable_banking' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: no match
|
|
enqueue({ data: [], error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-a', amount: -500 }), error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-b', amount: -500 }), error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.imported).toBe(2)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-quater. The cross-channel mirror is still subject to the account guard:
|
|
// a mirror match on a DIFFERENT known cash account is rejected, so a
|
|
// multi-account company never collapses a transaction across accounts.
|
|
// -----------------------------------------------------------------------
|
|
it('respects the cash-account guard on the cross-channel mirror path', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2025-10-23',
|
|
amount: -941,
|
|
description: 'Fortnox Finans AB',
|
|
external_id: 'nordea_business_xyz',
|
|
import_source: 'csv_nordea_business',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-acctB', amount: -941 })
|
|
|
|
// Booked transaction map query: none
|
|
enqueue({ data: [], error: null })
|
|
// Stored cross-feed twin, but it settled on a DIFFERENT account (A).
|
|
enqueue({
|
|
data: [{ date: '2025-10-23', amount: -941, original_description: '506401841738056', description: '506401841738056', import_source: 'enable_banking', cash_account_id: 'acct-A' }],
|
|
error: null,
|
|
})
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: no match
|
|
enqueue({ data: [], error: null })
|
|
// cash_accounts lookup → batch settled on account B
|
|
enqueue({ data: { id: 'acct-B' }, error: null })
|
|
// Insert: different account, not a duplicate
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-currency. The content bucket keys on (date, öre) with NO currency, so a
|
|
// 250,00 EUR row and a 250,00 SEK row on the same date share a bucket.
|
|
// Every match path (text bridge, cross-channel mirror, hand mirror) must
|
|
// refuse to consume across currencies: the swallowed row is a real
|
|
// affärshändelse that would never be bokförd, and only the aggregate
|
|
// duplicate count would hint that anything vanished.
|
|
// -----------------------------------------------------------------------
|
|
it('does not text-bridge-dedupe across currencies (250 EUR vs stored 250 SEK, identical titles)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Same feed on both sides, so the cross-channel mirror cannot fire: this
|
|
// isolates the description-bridge path, where the titles match EXACTLY.
|
|
const raw = makeRaw({
|
|
date: '2026-07-13',
|
|
amount: -250.0,
|
|
currency: 'EUR',
|
|
description: 'STRIPE PAYMENT',
|
|
external_id: 'eb_EU00_2026-07-13_-25000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-eur', external_id: raw.external_id, amount: -250.0 })
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-07-13', amount: -250.0,
|
|
original_description: 'STRIPE PAYMENT', description: 'STRIPE PAYMENT',
|
|
import_source: 'enable_banking', currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
}) // unbooked map: same title, same date, same öre, DIFFERENT currency
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert: kept
|
|
mockFetchExchangeRate.mockResolvedValue(null)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.transaction_ids).toEqual(['tx-eur'])
|
|
})
|
|
|
|
it('does not cross-channel-mirror-dedupe across currencies (CSV EUR vs stored PSD2 SEK)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Non-bridging titles + a count-symmetric bucket = the mirror WOULD fire on
|
|
// (date, öre) alone. The currency mismatch must keep it off.
|
|
const raw = makeRaw({
|
|
date: '2026-07-13',
|
|
amount: -941,
|
|
currency: 'EUR',
|
|
description: 'Fortnox Finans AB',
|
|
external_id: 'nordea_business_eur1',
|
|
import_source: 'csv_nordea_business',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-eur-mirror', external_id: raw.external_id, amount: -941 })
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-07-13', amount: -941,
|
|
original_description: '506401841738056', description: '506401841738056',
|
|
import_source: 'enable_banking', currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
}) // unbooked map: cross-feed twin by (date, öre), but in SEK
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert: kept
|
|
mockFetchExchangeRate.mockResolvedValue(null)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
it('still dedupes a genuine same-currency re-import (control for the currency guard)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Byte-identical to the text-bridge test above except the incoming currency
|
|
// matches the stored one: the guard must change nothing here.
|
|
const raw = makeRaw({
|
|
date: '2026-07-13',
|
|
amount: -250.0,
|
|
currency: 'SEK',
|
|
description: 'STRIPE PAYMENT',
|
|
external_id: 'eb_SE00_2026-07-13_-25000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-07-13', amount: -250.0,
|
|
original_description: 'STRIPE PAYMENT', description: 'STRIPE PAYMENT',
|
|
import_source: 'enable_banking', currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
}) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
// No insert: deduped by the text bridge, exactly as before the guard.
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
it('still dedupes against a stored row that carries no currency (legacy rows unchanged)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// A null currency on either side carries no contradiction, so it must stay
|
|
// bridge-allowed: rows predating the currency column dedup as they always
|
|
// did, even against a foreign-currency import.
|
|
const raw = makeRaw({
|
|
date: '2026-07-13',
|
|
amount: -250.0,
|
|
currency: 'EUR',
|
|
description: 'STRIPE PAYMENT',
|
|
external_id: 'eb_EU00_2026-07-13_-25000_9',
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-07-13', amount: -250.0,
|
|
original_description: 'STRIPE PAYMENT', description: 'STRIPE PAYMENT',
|
|
import_source: 'enable_banking', currency: null,
|
|
}],
|
|
error: null,
|
|
}) // unbooked map: legacy row, currency unknown
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
mockFetchExchangeRate.mockResolvedValue(null)
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-hand. Booked-hand-entered mirror: the user bookkeeps by chat/MCP FIRST
|
|
// (free-form Swedish title, booked), then connects the bank; the feed
|
|
// delivers the bank's copy of the same movement with a raw provider
|
|
// string that shares no text. Same (date, öre), count-symmetric bucket
|
|
// → deduped against the BOOKED hand-entered row.
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes an incoming feed row against a booked hand-entered (mcp) twin whose title does not bridge', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-06-24',
|
|
amount: -520,
|
|
description: 'PLAN_ORDER_CHECKOUT-invoice-11111 Account fee', // raw provider text
|
|
external_id: 'eb_SE00_2026-06-24_-52000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
// Booked map: the hand-entered MCP row the user already booked.
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-06-24', amount: -520,
|
|
original_description: 'Wise Business engångsavgift kontoöppning',
|
|
description: 'Wise Business engångsavgift kontoöppning',
|
|
import_source: 'mcp', bank_connection_id: null,
|
|
cash_account_id: null, currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // unbooked map: none
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: different namespace, no match
|
|
// No insert: deduped by the booked-hand-entered mirror.
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
it('never consumes an UNBOOKED hand-entered row (staged intent is not ledger evidence)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-06-24',
|
|
amount: -520,
|
|
description: 'PLAN_ORDER_CHECKOUT-invoice-11111 Account fee',
|
|
external_id: 'eb_SE00_2026-06-24_-52000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-kept', external_id: raw.external_id, amount: -520 })
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Unbooked map: even if an mcp row leaked in here, it must not be a mirror
|
|
// candidate (in production the query excludes manual/mcp at the DB level).
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-06-24', amount: -520,
|
|
original_description: 'Wise Business engångsavgift kontoöppning',
|
|
description: 'Wise Business engångsavgift kontoöppning',
|
|
import_source: 'mcp', bank_connection_id: null,
|
|
cash_account_id: null, currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert: NOT deduped
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
it('does not hand-entered-dedupe an asymmetric bucket (two incoming vs one booked mcp row)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const rows = [
|
|
makeRaw({ date: '2026-06-24', amount: -520, description: 'TRANSFER-1 Payment', external_id: 'eb_a', import_source: 'enable_banking' }),
|
|
makeRaw({ date: '2026-06-24', amount: -520, description: 'TRANSFER-2 Payment', external_id: 'eb_b', import_source: 'enable_banking' }),
|
|
]
|
|
|
|
// Booked map: ONE hand-entered row → incoming 2 vs stored 1 = asymmetric.
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-06-24', amount: -520,
|
|
original_description: 'Betalning till leverantör',
|
|
description: 'Betalning till leverantör',
|
|
import_source: 'mcp', bank_connection_id: null,
|
|
cash_account_id: null, currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: makeTransaction({ id: 'tx-a', amount: -520 }), error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-b', amount: -520 }), error: null })
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.imported).toBe(2)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
it('does not hand-entered-dedupe across currencies (SEK manual row vs USD feed row)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Numerically equal amounts land in the same (date, öre) bucket, but the
|
|
// currencies differ → the mirror must stay off.
|
|
const raw = makeRaw({
|
|
date: '2026-07-13',
|
|
amount: 2500,
|
|
currency: 'USD',
|
|
description: 'TRANSFER-9 Facilitation',
|
|
external_id: 'eb_US00_2026-07-13_250000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-usd', external_id: raw.external_id, amount: 2500 })
|
|
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-07-13', amount: 2500,
|
|
original_description: 'Kundinbetalning bankgiro',
|
|
description: 'Kundinbetalning bankgiro',
|
|
import_source: 'mcp', bank_connection_id: null,
|
|
cash_account_id: null, currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
}) // booked map: SEK hand-entered row, same date+öre
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert: kept
|
|
mockFetchExchangeRate.mockResolvedValue(null)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(mockGetBestInvoiceMatch).toHaveBeenCalled() // income path still runs
|
|
})
|
|
|
|
it('respects the cash-account guard on the booked-hand-entered mirror path', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-06-24',
|
|
amount: -520,
|
|
description: 'TRANSFER-5 Payment',
|
|
external_id: 'eb_acctB_2026-06-24_-52000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-acctB', amount: -520 })
|
|
|
|
// Booked hand-entered row explicitly bound to a DIFFERENT cash account.
|
|
enqueue({
|
|
data: [{
|
|
date: '2026-06-24', amount: -520,
|
|
original_description: 'Egen insättning',
|
|
description: 'Egen insättning',
|
|
import_source: 'mcp', bank_connection_id: null,
|
|
cash_account_id: 'acct-A', currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'acct-B' }, error: null }) // cash_accounts → batch on account B
|
|
enqueue({ data: inserted, error: null }) // insert: kept
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
it('stamps the batch cash account onto a consumed null-account hand row (one-consume-ever adoption)', async () => {
|
|
const { supabase, enqueue, updates } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-06-24',
|
|
amount: -520,
|
|
description: 'TRANSFER-5 Payment', // does not bridge the hand row's title
|
|
external_id: 'eb_acctA_2026-06-24_-52000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
// Booked MANUAL row, account-unbound (cash_account_id null).
|
|
enqueue({
|
|
data: [{
|
|
id: 'tx-hand-1',
|
|
date: '2026-06-24', amount: -520,
|
|
original_description: 'Egen insättning',
|
|
description: 'Egen insättning',
|
|
import_source: 'manual', bank_connection_id: null,
|
|
cash_account_id: null, currency: 'SEK',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'acct-A' }, error: null }) // cash_accounts → batch on account A
|
|
enqueue({ data: null, error: null }) // adoption stamp update
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1930',
|
|
})
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
// The hand row is now bound to account A, so it can never consume a feed
|
|
// row on another account in a later sync.
|
|
const txUpdates = (updates['transactions'] ?? []) as Record<string, unknown>[]
|
|
expect(txUpdates).toContainEqual({ cash_account_id: 'acct-A' })
|
|
})
|
|
|
|
it('does not let a Layer-1 duplicate inflate the hand-mirror symmetry count', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// R0 is already stored (Layer-1 kills it); R1 is genuinely new. TWO booked
|
|
// hand rows share the bucket. Coarse counting would say 2 incoming == 2
|
|
// stored and consume a hand row for R1; the honest unmatched count is
|
|
// 1 vs 2 → asymmetric → R1 must insert.
|
|
const rows = [
|
|
makeRaw({ date: '2026-06-24', amount: -520, description: 'TRANSFER-1 Pay', external_id: 'eb_stored_0', import_source: 'enable_banking' }),
|
|
makeRaw({ date: '2026-06-24', amount: -520, description: 'TRANSFER-2 Pay', external_id: 'eb_new_1', import_source: 'enable_banking' }),
|
|
]
|
|
const inserted = makeTransaction({ id: 'tx-new', amount: -520 })
|
|
|
|
enqueue({
|
|
data: [
|
|
{ id: 'h1', date: '2026-06-24', amount: -520, original_description: 'Hyra lokal', description: 'Hyra lokal', import_source: 'mcp', bank_connection_id: null, cash_account_id: null, currency: 'SEK' },
|
|
{ id: 'h2', date: '2026-06-24', amount: -520, original_description: 'Egen insättning', description: 'Egen insättning', import_source: 'mcp', bank_connection_id: null, cash_account_id: null, currency: 'SEK' },
|
|
],
|
|
error: null,
|
|
}) // booked map: two hand rows
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [{ external_id: 'eb_stored_0' }], error: null }) // external_id dedup: R0 already stored
|
|
enqueue({ data: inserted, error: null }) // insert R1: kept
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.duplicates).toBe(1) // R0 via Layer-1 only
|
|
expect(result.imported).toBe(1) // R1 inserted, no hand row consumed
|
|
})
|
|
|
|
it('excludes account-incompatible hand rows from the symmetry count (no mirror flip)', async () => {
|
|
const { supabase, enqueue, updates } = createQueueMockSupabase()
|
|
// Batch settles on account B. Stored: M1 (account-unbound) and M2 (bound to
|
|
// account A). If M2 were counted, 2 incoming == 2 stored would switch the
|
|
// mirror on and the non-bridging R1 would wrongly consume M1. With the
|
|
// guard applied to the COUNT, symmetry is 2 vs 1 → mirror off → R1 inserts
|
|
// and R2 dedups via its text bridge against M1.
|
|
const rows = [
|
|
makeRaw({ date: '2026-06-24', amount: -10000, description: 'TRANSFER-7 Pay', external_id: 'eb_r1', import_source: 'enable_banking' }),
|
|
makeRaw({ date: '2026-06-24', amount: -10000, description: 'Hyra avtal 12 betalning juni', external_id: 'eb_r2', import_source: 'enable_banking' }),
|
|
]
|
|
const inserted = makeTransaction({ id: 'tx-r1', amount: -10000 })
|
|
|
|
enqueue({
|
|
data: [
|
|
{ id: 'm1', date: '2026-06-24', amount: -10000, original_description: 'Hyra avtal 12', description: 'Hyra avtal 12', import_source: 'mcp', bank_connection_id: null, cash_account_id: null, currency: 'SEK' },
|
|
{ id: 'm2', date: '2026-06-24', amount: -10000, original_description: 'Hyra avtal 12', description: 'Hyra avtal 12', import_source: 'mcp', bank_connection_id: null, cash_account_id: 'acct-A', currency: 'SEK' },
|
|
],
|
|
error: null,
|
|
}) // booked map
|
|
enqueue({ data: [], error: null }) // unbooked map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'acct-B' }, error: null }) // cash_accounts → account B
|
|
enqueue({ data: inserted, error: null }) // insert R1
|
|
enqueue({ data: null, error: null }) // adoption stamp for M1 (text-bridged by R2)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows, {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1) // R1 kept (genuinely new)
|
|
expect(result.duplicates).toBe(1) // R2 text-bridged M1
|
|
// The text-bridge consumption also binds M1 to account B.
|
|
const txUpdates = (updates['transactions'] ?? []) as Record<string, unknown>[]
|
|
expect(txUpdates).toContainEqual({ cash_account_id: 'acct-B' })
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2c-shadow. Same-feed scope-drift (Hole A): SHADOW MODE. Enable Banking
|
|
// returns the same account under a drifted IBAN, so the IBAN-embedded
|
|
// external_id is new (Layer-1 misses) and, because both rows are the SAME
|
|
// feed, the cross-channel mirror does not fire. The shadow detector
|
|
// MEASURES how often an enforcing rule would treat this as a re-import: // it logs/counts but NEVER changes what is inserted. These tests pin both
|
|
// that it detects the real case and, crucially, that it never flags a
|
|
// genuine row (the only failure mode that would matter).
|
|
// -----------------------------------------------------------------------
|
|
it('shadow-flags a same-feed scope-drift re-import but still imports it (no behavior change)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Same account re-fetched under a drifted IBAN → new external_id, and a
|
|
// description that shares no prefix with the stored row (so the text bridge
|
|
// cannot catch it either: this is purely the scope-drift signal).
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -250,
|
|
description: 'TELENOR SVERIGE',
|
|
external_id: 'eb_SE_NEW_2024-06-15_-25000_0',
|
|
import_source: 'enable_banking',
|
|
bank_connection_id: 'conn-1',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-new', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Unbooked map: the stored twin from the SAME feed under the OLD id scope.
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-15', amount: -250,
|
|
original_description: 'LOAN PAYMENT 19', description: 'LOAN PAYMENT 19',
|
|
import_source: 'enable_banking', bank_connection_id: 'conn-1',
|
|
cash_account_id: 'ca-1930', external_id: 'eb_SE_OLD_2024-06-15_-25000_0',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices: none
|
|
enqueue({ data: [], error: null }) // external_id dedup: OLD id not among incoming NEW ids
|
|
enqueue({ data: { id: 'ca-1930' }, error: null }) // cash_accounts: same account as the stored row
|
|
enqueue({ data: inserted, error: null }) // insert: STILL imported (shadow only logs)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1930',
|
|
})
|
|
|
|
// Detected, but NOT acted on: imports exactly as before.
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.shadow_scope_drift_candidates).toBe(1)
|
|
})
|
|
|
|
it('does not shadow-flag an asymmetric same-feed bucket (counts differ)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// TWO incoming rows share (date, amount) but only ONE stored twin exists →
|
|
// the channels disagree on how many transactions the bucket holds, so the
|
|
// signal is ambiguous and we stay silent.
|
|
const rows = [
|
|
makeRaw({ date: '2024-06-15', amount: -250, description: 'BETALNING A', external_id: 'eb_NEW_a', import_source: 'enable_banking' }),
|
|
makeRaw({ date: '2024-06-15', amount: -250, description: 'BETALNING B', external_id: 'eb_NEW_b', import_source: 'enable_banking' }),
|
|
]
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, original_description: 'OCR 9988', description: 'OCR 9988', import_source: 'enable_banking', cash_account_id: null, external_id: 'eb_OLD_x' }],
|
|
error: null,
|
|
}) // unbooked: ONE stored twin
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: makeTransaction({ id: 'tx-a' }), error: null }) // insert a
|
|
enqueue({ data: makeTransaction({ id: 'tx-b' }), error: null }) // insert b
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.imported).toBe(2)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.shadow_scope_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('does not shadow-flag when the stored twin is on a different known cash account', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ date: '2024-06-15', amount: -250, description: 'TELENOR', external_id: 'eb_NEW_acctB', import_source: 'enable_banking' })
|
|
const inserted = makeTransaction({ id: 'tx-b', external_id: raw.external_id })
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, original_description: 'OCR', description: 'OCR', import_source: 'enable_banking', cash_account_id: 'acct-A', external_id: 'eb_OLD_acctA' }],
|
|
error: null,
|
|
}) // unbooked twin on account A
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'acct-B' }, error: null }) // cash_accounts → batch settled on account B
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], { settlementAccount: '1931' })
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.shadow_scope_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('does not shadow-flag a genuinely new row when the stored sibling id re-arrives (not drift)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// The stored row's id IS present in this batch (normal re-sync, no drift) →
|
|
// Layer-1 dedupes it. The SECOND incoming row is a genuinely new same-day /
|
|
// same-amount transaction with a non-bridging description: it must import
|
|
// AND must NOT be shadow-flagged, because the stored sibling is not
|
|
// "orphaned" by a drifted id. This is the data-loss guard.
|
|
const rows = [
|
|
makeRaw({ date: '2024-06-15', amount: -250, description: 'COFFEE STARBUCKS', external_id: 'eb_X_0', import_source: 'enable_banking' }),
|
|
makeRaw({ date: '2024-06-15', amount: -250, description: 'LUNCH RESTAURANG', external_id: 'eb_X_1', import_source: 'enable_banking' }),
|
|
]
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, original_description: 'COFFEE STARBUCKS', description: 'COFFEE STARBUCKS', import_source: 'enable_banking', cash_account_id: null, external_id: 'eb_X_0' }],
|
|
error: null,
|
|
}) // stored = the _0 sibling
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [{ external_id: 'eb_X_0' }], error: null }) // external_id dedup → eb_X_0 matches stored
|
|
enqueue({ data: makeTransaction({ id: 'tx-x1' }), error: null }) // insert eb_X_1 only
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.duplicates).toBe(1) // eb_X_0 deduped by Layer-1
|
|
expect(result.imported).toBe(1) // eb_X_1 (genuine new) imported
|
|
expect(result.shadow_scope_drift_candidates).toBe(0) // and NOT shadow-flagged
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2d. Description drift: PSD2 enrichment is prefix-preserving, so an
|
|
// enriched re-import ("TIC" → "TIC BG … via internet") still bridges
|
|
// the stored original via prefix-containment. This is the June 2026
|
|
// incident: the external_id ALSO changed, so the bridge is the only net.
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes an enriched re-import whose description extends the stored original', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-04-07',
|
|
amount: -11231,
|
|
description: 'KAFFE BG 0000000000 Bg-bet. via internet', // enriched
|
|
external_id: 'eb_SE00_2026-04-07_-1123100_0', // NEW-scheme id → external_id dedup misses
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Unbooked enable_banking row carrying the SHORT original description.
|
|
enqueue({
|
|
data: [{ date: '2026-04-07', amount: -11231, original_description: 'KAFFE', description: 'KAFFE' }],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: different scheme, no match
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2e. Order-independence: a genuinely-new row whose description does NOT
|
|
// bridge an existing same-(date,amount) row is kept, and the re-import
|
|
// that DOES bridge is deduped, regardless of provider ordering.
|
|
// -----------------------------------------------------------------------
|
|
it.each([
|
|
['new-first', ['Lunch', 'Coffee']],
|
|
['dup-first', ['Coffee', 'Lunch']],
|
|
])('keeps the distinct row and dedupes the bridging twin (%s)', async (_label, order) => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const rows = order.map((desc, i) =>
|
|
makeRaw({
|
|
date: '2026-04-07',
|
|
amount: -250,
|
|
description: desc,
|
|
external_id: `csv_${desc}_${i}`,
|
|
import_source: 'csv_lunar',
|
|
}),
|
|
)
|
|
const insertedDesc = 'Lunch' // the non-bridging "Lunch" is always the row that gets inserted
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// One unbooked enable_banking row "Coffee": only the incoming "Coffee" bridges it.
|
|
enqueue({
|
|
data: [{ date: '2026-04-07', amount: -250, original_description: 'Coffee', description: 'Coffee' }],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
enqueue({
|
|
data: makeTransaction({ id: 'tx-lunch', description: insertedDesc, amount: -250 }),
|
|
error: null,
|
|
}) // insert for the non-bridging "Lunch"
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.imported).toBe(1) // "Lunch" kept
|
|
expect(result.duplicates).toBe(1) // "Coffee" deduped
|
|
expect(result.transaction_ids).toEqual(['tx-lunch'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2f. Counting semantics: N stored twins dedup exactly N incoming bridging
|
|
// rows; the surplus is inserted (never silently collapsed).
|
|
// -----------------------------------------------------------------------
|
|
it('dedupes exactly as many incoming rows as there are stored twins (counting)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const rows = [1, 2, 3].map((n) =>
|
|
makeRaw({
|
|
date: '2026-04-07',
|
|
amount: -100,
|
|
description: `ICA Kortköp ${n}`,
|
|
external_id: `csv_ica_${n}`,
|
|
import_source: 'csv_lunar',
|
|
}),
|
|
)
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Two stored unbooked "ICA" twins → only two of the three incoming dedup.
|
|
enqueue({
|
|
data: [
|
|
{ date: '2026-04-07', amount: -100, original_description: 'ICA', description: 'ICA' },
|
|
{ date: '2026-04-07', amount: -100, original_description: 'ICA', description: 'ICA' },
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
enqueue({
|
|
data: makeTransaction({ id: 'tx-ica-surplus', description: 'ICA Kortköp 3', amount: -100 }),
|
|
error: null,
|
|
}) // insert for the surplus third row
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, rows)
|
|
|
|
expect(result.duplicates).toBe(2)
|
|
expect(result.imported).toBe(1)
|
|
expect(result.transaction_ids).toEqual(['tx-ica-surplus'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2g. Cross-account guard: a transaction on one bank account must NOT
|
|
// deduplicate a genuinely-different one on ANOTHER account of the same
|
|
// company. The content bucket is company-wide (only external_id embeds
|
|
// the account), so the bridge also requires matching cash_account_id when
|
|
// both sides know it.
|
|
// -----------------------------------------------------------------------
|
|
it('does not dedupe a bridging twin that settled on a different cash account', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-04-07',
|
|
amount: -250,
|
|
description: 'Avgift',
|
|
external_id: 'eb_acctB_2026-04-07_-25000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-acctB', amount: -250 })
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Unbooked enable_banking twin, but it settled on a DIFFERENT account (A).
|
|
enqueue({
|
|
data: [{ date: '2026-04-07', amount: -250, original_description: 'Avgift', description: 'Avgift', cash_account_id: 'acct-A' }],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
enqueue({ data: { id: 'acct-B' }, error: null }) // cash_accounts lookup → batch settled on account B
|
|
enqueue({ data: inserted, error: null }) // insert: not a duplicate
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.transaction_ids).toEqual(['tx-acctB'])
|
|
})
|
|
|
|
it('dedupes a bridging twin on the SAME cash account', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-04-07',
|
|
amount: -250,
|
|
description: 'Avgift',
|
|
external_id: 'eb_acctA_2026-04-07_-25000_99', // different id → external_id dedup misses
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
enqueue({
|
|
data: [{ date: '2026-04-07', amount: -250, original_description: 'Avgift', description: 'Avgift', cash_account_id: 'acct-A' }],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
enqueue({ data: { id: 'acct-A' }, error: null }) // cash_accounts lookup → batch settled on account A (same)
|
|
// No insert: deduped.
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1930',
|
|
})
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 2h-shadow. Date-drift (the residual gap behind the reported bank↔bank dupes).
|
|
// Every dedup layer buckets on EXACT (date, öre), so a twin whose booking
|
|
// date drifted a day is invisible to all of them. The date-drift shadow
|
|
// MEASURES how often a ±1-day rule would fire: it logs/counts but NEVER
|
|
// changes what is inserted. These pin both that it detects the real cases
|
|
// and, crucially, that it never flags a genuine row.
|
|
// -----------------------------------------------------------------------
|
|
it('shadow-flags an EB↔EB twin one day apart with a bridging description, but still imports it', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Same hotel expense, booking date drifted 15→16 (a real date-drift case).
|
|
const raw = makeRaw({
|
|
date: '2024-06-16',
|
|
amount: -1500,
|
|
description: 'Hotel expense',
|
|
external_id: 'eb_SE_2024-06-16_-150000_0',
|
|
import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-drift', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
// Unbooked EB twin one day earlier: same amount/desc/account, OLD-scheme id.
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-15', amount: -1500,
|
|
original_description: 'Hotel expense', description: 'Hotel expense',
|
|
import_source: 'enable_banking', bank_connection_id: 'conn-1',
|
|
cash_account_id: 'ca-1930', external_id: 'eb_SE_2024-06-15_-150000_0',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: different date bucket, no match
|
|
enqueue({ data: { id: 'ca-1930' }, error: null }) // cash_accounts: same account
|
|
enqueue({ data: inserted, error: null }) // insert: STILL imported (shadow only logs)
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1930',
|
|
})
|
|
|
|
// Detected, but NOT acted on: imports exactly as before.
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.shadow_date_drift_candidates).toBe(1)
|
|
// A different (adjacent) bucket → this is date-drift, not same-bucket scope-drift.
|
|
expect(result.shadow_scope_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('shadow-flags a CSV↔EB twin one day apart via cross-channel symmetry when descriptions do not bridge', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// Nordea CSV row (payee-only desc) and its PSD2 twin booked a day later
|
|
// (OCR/message desc): descriptions share no prefix, so only the
|
|
// cross-channel mirror DISPLACED by a day can catch it (a real date-drift case).
|
|
const raw = makeRaw({
|
|
date: '2024-06-15',
|
|
amount: -2500,
|
|
description: 'Nordea',
|
|
external_id: 'nordea_business_csvhash',
|
|
import_source: 'csv_nordea_business',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-cross', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked map: none
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-16', amount: -2500,
|
|
original_description: 'Reimbursement', description: 'Reimbursement',
|
|
import_source: 'enable_banking', bank_connection_id: 'conn-1',
|
|
cash_account_id: null, external_id: 'eb_SE_2024-06-16_-250000_0',
|
|
}],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
enqueue({ data: inserted, error: null }) // insert: STILL imported
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.shadow_date_drift_candidates).toBe(1)
|
|
})
|
|
|
|
it('does not shadow-flag a date-drift twin on a different known cash account', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-16', amount: -250, description: 'Hotel expense',
|
|
external_id: 'eb_acctB_2024-06-16_-25000_0', import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-b', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-15', amount: -250,
|
|
original_description: 'Hotel expense', description: 'Hotel expense',
|
|
import_source: 'enable_banking', cash_account_id: 'acct-A',
|
|
external_id: 'eb_acctA_2024-06-15_-25000_0',
|
|
}],
|
|
error: null,
|
|
}) // bridging twin one day earlier, but on account A
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: { id: 'acct-B' }, error: null }) // cash_accounts → batch on account B
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw], {
|
|
settlementAccount: '1931',
|
|
})
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.shadow_date_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('does not shadow-flag a twin two days away (outside the ±1-day window)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-17', amount: -250, description: 'Hotel expense',
|
|
external_id: 'eb_2024-06-17_-25000_0', import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-far', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-15', amount: -250,
|
|
original_description: 'Hotel expense', description: 'Hotel expense',
|
|
import_source: 'enable_banking', cash_account_id: null,
|
|
external_id: 'eb_2024-06-15_-25000_0',
|
|
}],
|
|
error: null,
|
|
}) // bridging twin TWO days earlier
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.shadow_date_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('does not shadow-flag two genuinely-distinct same-amount rows a day apart (non-bridging, same feed)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-16', amount: -250, description: 'LUNCH RESTAURANG',
|
|
external_id: 'eb_2024-06-16_-25000_0', import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-lunch', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({
|
|
data: [{
|
|
date: '2024-06-15', amount: -250,
|
|
original_description: 'COFFEE STARBUCKS', description: 'COFFEE STARBUCKS',
|
|
import_source: 'enable_banking', cash_account_id: null,
|
|
external_id: 'eb_2024-06-15_-25000_0',
|
|
}],
|
|
error: null,
|
|
}) // distinct same-amount neighbour, same feed, non-bridging desc
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.shadow_date_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('does not double-count: an exact-date Layer-2 dedupe is not also a date-drift candidate', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2024-06-15', amount: -250, description: 'KAFFE',
|
|
external_id: 'eb_new_2024-06-15_-25000_0', import_source: 'enable_banking',
|
|
})
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
// Two stored twins: one EXACT-date (Layer-2 dedupes it) and one a day later.
|
|
// The row is consumed by Layer-2 and never reaches the date-drift gate.
|
|
enqueue({
|
|
data: [
|
|
{ date: '2024-06-15', amount: -250, original_description: 'KAFFE', description: 'KAFFE',
|
|
import_source: 'enable_banking', cash_account_id: null, external_id: 'eb_old_0615' },
|
|
{ date: '2024-06-16', amount: -250, original_description: 'KAFFE', description: 'KAFFE',
|
|
import_source: 'enable_banking', cash_account_id: null, external_id: 'eb_old_0616' },
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup: no match
|
|
// No insert: deduped by Layer-2.
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
expect(result.shadow_date_drift_candidates).toBe(0)
|
|
})
|
|
|
|
it('never lets the date-drift measurement break an import (malformed date is fail-safe)', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
// A malformed date would make shiftIsoDate throw; the guard must skip
|
|
// detection so the row imports exactly as before: measurement can never
|
|
// abort a sync. (Without the guard this test throws instead of asserting.)
|
|
const raw = makeRaw({
|
|
date: 'not-a-date', amount: -250, description: 'Hotel expense',
|
|
external_id: 'eb_bad_date_0', import_source: 'enable_banking',
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-baddate', external_id: raw.external_id })
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({ data: [], error: null }) // unbooked
|
|
enqueue({ data: [], error: null }) // supplier
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert: still happens
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.shadow_date_drift_candidates).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 3. Counts errors when insert fails
|
|
// -----------------------------------------------------------------------
|
|
it('counts errors when insert fails', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw()
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert fails
|
|
enqueue({ data: null, error: { message: 'DB constraint violation' } })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.errors).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
expect(result.transaction_ids).toEqual([])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 4. Auto-matches invoices for income transactions (amount > 0)
|
|
// -----------------------------------------------------------------------
|
|
it('auto-matches invoices for income transactions', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: 5000, description: 'Payment received' })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-income',
|
|
amount: 5000,
|
|
external_id: raw.external_id,
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert returns the new transaction
|
|
enqueue({ data: inserted, error: null })
|
|
// Invoice match update (supabase.from('transactions').update(...))
|
|
enqueue({ data: null, error: null })
|
|
// Mapping rules auto-categorization update (if triggered)
|
|
enqueue({ data: null, error: null })
|
|
|
|
mockGetBestInvoiceMatch.mockResolvedValue({
|
|
invoice: { id: 'inv-1' },
|
|
confidence: 0.95,
|
|
matchReason: 'OCR reference match',
|
|
})
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.auto_matched_invoices).toBe(1)
|
|
expect(mockGetBestInvoiceMatch).toHaveBeenCalledWith(
|
|
expect.anything(), // supabase client
|
|
COMPANY_ID,
|
|
expect.objectContaining({ id: 'tx-income' }),
|
|
0.50
|
|
)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 4b. Supplier-invoice match at sync is ALWAYS a suggestion, never a hard
|
|
// link. Regression: a high-confidence hit used to set
|
|
// supplier_invoice_id directly (with no payment voucher booked) which
|
|
// then BLOCKED the match route (MATCH_SI_TX_ALREADY_LINKED), stranding
|
|
// the bank line with no path to a payment booking (June 2026 incident:
|
|
// RosholmDell 18299).
|
|
// -----------------------------------------------------------------------
|
|
it('demotes a high-confidence supplier-invoice match to potential_supplier_invoice_id', async () => {
|
|
const { supabase, enqueue, updates } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
date: '2026-06-08',
|
|
amount: -29890,
|
|
description: 'RosholmDell Advo BG 0000007746514 Bg-bet. via internet',
|
|
})
|
|
const inserted = makeTransaction({
|
|
id: 'tx-rd',
|
|
amount: -29890,
|
|
date: '2026-06-08',
|
|
external_id: raw.external_id,
|
|
})
|
|
// One unpaid invoice, exact amount, tx date inside the credit window →
|
|
// Pass-3 amount_date match at 0.85, unambiguous (previously: hard link).
|
|
const supplierInvoice = {
|
|
id: 'si-rd',
|
|
status: 'registered',
|
|
total: 29890,
|
|
remaining_amount: 29890,
|
|
invoice_date: '2026-06-05',
|
|
due_date: '2026-07-05',
|
|
payment_reference: null,
|
|
supplier: { name: 'RosholmDell Advokatbyrå AB' },
|
|
}
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({ data: [], error: null }) // unbooked bank-synced map
|
|
enqueue({ data: [supplierInvoice], error: null }) // supplier invoices pool
|
|
enqueue({ data: [], error: null }) // external_id dedup
|
|
enqueue({ data: inserted, error: null }) // insert
|
|
enqueue({ data: null, error: null }) // suggestion update
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.auto_matched_invoices).toBe(1)
|
|
const txUpdates = (updates['transactions'] ?? []) as Record<string, unknown>[]
|
|
expect(txUpdates).toHaveLength(1)
|
|
expect(txUpdates[0]).toEqual({ potential_supplier_invoice_id: 'si-rd' })
|
|
// The hard link is reserved for completed matches (payment voucher booked).
|
|
expect(txUpdates.some((u) => 'supplier_invoice_id' in u)).toBe(false)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 5. Does not attempt invoice matching for expenses (amount < 0)
|
|
// -----------------------------------------------------------------------
|
|
it('does not attempt invoice matching for expenses', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -350 })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-expense',
|
|
amount: -350,
|
|
external_id: raw.external_id,
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.auto_matched_invoices).toBe(0)
|
|
expect(mockGetBestInvoiceMatch).not.toHaveBeenCalled()
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 6. Auto-categorizes when mapping confidence >= 0.8
|
|
// -----------------------------------------------------------------------
|
|
it('auto-categorizes when mapping confidence is at least 0.8', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -500, mcc_code: 5411, merchant_name: 'ICA' })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-cat',
|
|
amount: -500,
|
|
external_id: raw.external_id,
|
|
})
|
|
const journalEntry = makeJournalEntry({ id: 'je-1' })
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
// Update after journal entry creation
|
|
enqueue({ data: null, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(
|
|
makeMappingResult({ confidence: 0.85, requires_review: false })
|
|
)
|
|
mockCreateTransactionJournalEntry.mockResolvedValue(journalEntry)
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.auto_categorized).toBe(1)
|
|
expect(mockCreateTransactionJournalEntry).toHaveBeenCalledWith(
|
|
expect.anything(),
|
|
COMPANY_ID,
|
|
USER_ID,
|
|
expect.objectContaining({ id: 'tx-cat' }),
|
|
expect.objectContaining({ confidence: 0.85 })
|
|
)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 7. Skips auto-categorization when confidence < 0.8
|
|
// -----------------------------------------------------------------------
|
|
it('skips auto-categorization when confidence is below 0.8', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -200 })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-lowconf',
|
|
amount: -200,
|
|
external_id: raw.external_id,
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(
|
|
makeMappingResult({ confidence: 0.6 })
|
|
)
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.auto_categorized).toBe(0)
|
|
expect(mockCreateTransactionJournalEntry).not.toHaveBeenCalled()
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 7b. Skips auto-categorization when requires_review is true
|
|
// -----------------------------------------------------------------------
|
|
it('skips auto-categorization when requires_review is true even if confidence is high', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -800 })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-review',
|
|
amount: -800,
|
|
external_id: raw.external_id,
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(
|
|
makeMappingResult({ confidence: 0.95, requires_review: true })
|
|
)
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.auto_categorized).toBe(0)
|
|
expect(mockCreateTransactionJournalEntry).not.toHaveBeenCalled()
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 8. Returns correct IngestResult totals
|
|
// -----------------------------------------------------------------------
|
|
it('returns correct IngestResult totals', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw1 = makeRaw({ external_id: 'ext-a', amount: -100 })
|
|
const raw2 = makeRaw({ external_id: 'ext-b', amount: -200 })
|
|
|
|
const inserted1 = makeTransaction({ id: 'tx-a', amount: -100 })
|
|
const inserted2 = makeTransaction({ id: 'tx-b', amount: -200 })
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Transaction 1: insert OK
|
|
enqueue({ data: inserted1, error: null })
|
|
// Transaction 2: insert OK
|
|
enqueue({ data: inserted2, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw1, raw2])
|
|
|
|
expect(result.imported).toBe(2)
|
|
expect(result.duplicates).toBe(0)
|
|
expect(result.errors).toBe(0)
|
|
expect(result.auto_categorized).toBe(0)
|
|
expect(result.auto_matched_invoices).toBe(0)
|
|
expect(result.transaction_ids).toEqual(['tx-a', 'tx-b'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// 9. Handles mixed batch (new, duplicates, errors)
|
|
// -----------------------------------------------------------------------
|
|
it('handles a mixed batch of new transactions, duplicates, and errors', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
|
|
const rawNew = makeRaw({ external_id: 'ext-new', amount: 3000 })
|
|
const rawDup = makeRaw({ external_id: 'ext-dup', amount: -150 })
|
|
const rawErr = makeRaw({ external_id: 'ext-err', amount: -75 })
|
|
|
|
const insertedNew = makeTransaction({
|
|
id: 'tx-new',
|
|
amount: 3000,
|
|
external_id: 'ext-new',
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: ext-dup already exists
|
|
enqueue({ data: [{ external_id: 'ext-dup' }], error: null })
|
|
// Transaction rawNew: insert OK
|
|
enqueue({ data: insertedNew, error: null })
|
|
// Invoice match update for income transaction
|
|
enqueue({ data: null, error: null })
|
|
// logMatchEvent insert (fire-and-forget)
|
|
enqueue({ data: null, error: null })
|
|
// rawDup: skipped (in Set): no queue entry needed
|
|
// NOTE: auto-categorization is skipped because invoice match triggers `continue`
|
|
// Transaction rawErr: insert fails
|
|
enqueue({ data: null, error: { message: 'Insert failed' } })
|
|
|
|
// Income transaction gets an invoice match
|
|
mockGetBestInvoiceMatch.mockResolvedValue({
|
|
invoice: { id: 'inv-match' },
|
|
confidence: 0.95,
|
|
matchReason: 'Exact amount match',
|
|
})
|
|
|
|
// Auto-categorization with high confidence
|
|
mockEvaluateMappingRules.mockResolvedValue(
|
|
makeMappingResult({ confidence: 0.85 })
|
|
)
|
|
const journalEntry = makeJournalEntry({ id: 'je-mixed' })
|
|
mockCreateTransactionJournalEntry.mockResolvedValue(journalEntry)
|
|
|
|
const result = await ingestTransactions(
|
|
supabase as never,
|
|
COMPANY_ID,
|
|
USER_ID,
|
|
[rawNew, rawDup, rawErr]
|
|
)
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.errors).toBe(1)
|
|
expect(result.auto_matched_invoices).toBe(1)
|
|
expect(result.auto_categorized).toBe(0) // Skipped: invoice match triggers continue
|
|
expect(result.transaction_ids).toEqual(['tx-new'])
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Edge: empty input array
|
|
// -----------------------------------------------------------------------
|
|
it('returns zero totals for an empty input array', async () => {
|
|
const { supabase } = createQueueMockSupabase()
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [])
|
|
|
|
expect(result).toEqual({
|
|
imported: 0,
|
|
duplicates: 0,
|
|
reconciled: 0,
|
|
auto_categorized: 0,
|
|
auto_matched_invoices: 0,
|
|
errors: 0,
|
|
transaction_ids: [],
|
|
shadow_scope_drift_candidates: 0,
|
|
shadow_date_drift_candidates: 0,
|
|
})
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Edge: invoice matching error is non-critical
|
|
// -----------------------------------------------------------------------
|
|
it('continues processing when invoice matching throws', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: 1000 })
|
|
const inserted = makeTransaction({ id: 'tx-inv-err', amount: 1000 })
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockGetBestInvoiceMatch.mockRejectedValue(new Error('Network error'))
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
// Should still count as imported even though invoice matching failed
|
|
expect(result.imported).toBe(1)
|
|
expect(result.auto_matched_invoices).toBe(0)
|
|
expect(result.errors).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Edge: auto-categorization error is non-critical
|
|
// -----------------------------------------------------------------------
|
|
it('continues processing when auto-categorization throws', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -400 })
|
|
const inserted = makeTransaction({ id: 'tx-cat-err', amount: -400 })
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockRejectedValue(new Error('Mapping error'))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.auto_categorized).toBe(0)
|
|
expect(result.errors).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Imports never auto-link to existing journal entries.
|
|
// Reconciliation must be an explicit user action (manualLink / runReconciliation).
|
|
// Regression: viktor@frnzn.com, bank txns from 2026 were silently linked
|
|
// to SIE-imported vouchers, surfacing them as "bokförda" without action.
|
|
// -----------------------------------------------------------------------
|
|
it('never auto-reconciles imported transactions to existing GL lines', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -500, external_id: 'ext-recon' })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-recon',
|
|
amount: -500,
|
|
external_id: 'ext-recon',
|
|
currency: 'SEK',
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.reconciled).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// rawInsertOnly: skips reconciliation, matching, and auto-categorization
|
|
// -----------------------------------------------------------------------
|
|
it('skips reconciliation, matching, and categorization when rawInsertOnly is set', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: 5000, description: 'Payment received' })
|
|
const inserted = makeTransaction({
|
|
id: 'tx-raw',
|
|
amount: 5000,
|
|
external_id: raw.external_id,
|
|
})
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// No supplier invoices fetch (skipped by rawInsertOnly)
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert returns the new transaction
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
const result = await ingestTransactions(
|
|
supabase as never, COMPANY_ID, USER_ID, [raw],
|
|
{ rawInsertOnly: true }
|
|
)
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.reconciled).toBe(0)
|
|
expect(result.auto_categorized).toBe(0)
|
|
expect(result.auto_matched_invoices).toBe(0)
|
|
// Should NOT have attempted any post-insert operations
|
|
expect(mockGetBestInvoiceMatch).not.toHaveBeenCalled()
|
|
expect(mockEvaluateMappingRules).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('still deduplicates when rawInsertOnly is set', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ external_id: 'ext-dup-raw' })
|
|
|
|
// Booked transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: already exists
|
|
enqueue({ data: [{ external_id: 'ext-dup-raw' }], error: null })
|
|
|
|
const result = await ingestTransactions(
|
|
supabase as never, COMPANY_ID, USER_ID, [raw],
|
|
{ rawInsertOnly: true }
|
|
)
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// Content-based dedup: cross-source duplicate detection
|
|
// -----------------------------------------------------------------------
|
|
it('skips transactions that match already-booked ones by date+amount+description', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
external_id: 'psd2_conn123_tx456',
|
|
date: '2024-06-15',
|
|
amount: -250,
|
|
})
|
|
|
|
// Booked transaction map returns a booked tx with same date+amount+description
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, description: raw.description }],
|
|
error: null,
|
|
})
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no match by external_id)
|
|
enqueue({ data: [], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
it('imports transactions when booked ones have different amounts', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
external_id: 'psd2_conn123_tx789',
|
|
date: '2024-06-15',
|
|
amount: -300,
|
|
})
|
|
const inserted = makeTransaction({ id: 'tx-new', amount: -300 })
|
|
|
|
// Booked transaction map: same date but different amount
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, description: raw.description }],
|
|
error: null,
|
|
})
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no match)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
|
|
it('bridges the external_id scheme change: a booked OLD-scheme eb_ row is caught by content dedup on re-sync', async () => {
|
|
// Transition scenario: an enable_banking row was imported+booked under the
|
|
// OLD unstable scheme (eb_{iban}_{txid}). After deploy, the re-sync derives
|
|
// a NEW content-based external_id that will NOT match by external_id, so
|
|
// layer-1 misses. Layer 1b (booked content dedup) MUST catch it, otherwise
|
|
// the user sees the exact duplicate the fix is meant to prevent.
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
external_id: 'eb_SE123_2024-06-15_-25000_0', // new scheme
|
|
date: '2024-06-15',
|
|
amount: -250,
|
|
description: 'ICA Maxi Solna',
|
|
import_source: 'enable_banking',
|
|
})
|
|
|
|
// Booked map: the SAME transaction still carries its OLD-scheme external_id
|
|
// in the DB; dedup matches on content, not on external_id.
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: -250, description: 'ICA Maxi Solna' }],
|
|
error: null,
|
|
})
|
|
// Unbooked enable_banking map: none
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query: DB still holds eb_SE123_{old_txid}, so the
|
|
// new external_id finds NO match here.
|
|
enqueue({ data: [], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
it('dedupes against a booked row whose amount is a numeric string (PostgREST), not a number', async () => {
|
|
// Regression: PostgREST can serialize a `numeric` column as a string
|
|
// ("-250.00") while the incoming raw amount is a JS number (-250). Before
|
|
// the öre-normalized dedup key these never compared equal, so content dedup
|
|
// silently missed and the row was re-imported as a duplicate.
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({
|
|
external_id: 'eb_acc_2024-06-15_-25000_0',
|
|
date: '2024-06-15',
|
|
amount: -250,
|
|
description: 'ICA Maxi Solna',
|
|
})
|
|
|
|
// Booked map: same transaction, amount as a STRING with trailing zeros.
|
|
enqueue({
|
|
data: [{ date: '2024-06-15', amount: '-250.00', description: 'ICA Maxi Solna' }],
|
|
error: null,
|
|
})
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no match by external_id: the id scheme changed)
|
|
enqueue({ data: [], error: null })
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.duplicates).toBe(1)
|
|
expect(result.imported).toBe(0)
|
|
})
|
|
|
|
it('handles multiple booked transactions with same date+amount correctly', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
|
|
// Three incoming transactions with the same date+amount
|
|
const raw1 = makeRaw({ external_id: 'psd2_a', date: '2024-06-15', amount: -100 })
|
|
const raw2 = makeRaw({ external_id: 'psd2_b', date: '2024-06-15', amount: -100 })
|
|
const raw3 = makeRaw({ external_id: 'psd2_c', date: '2024-06-15', amount: -100 })
|
|
|
|
const inserted = makeTransaction({ id: 'tx-new', amount: -100 })
|
|
|
|
// Booked map: 2 existing booked transactions with same date+amount+description
|
|
// So 2 of the 3 incoming should be skipped, 1 should be imported
|
|
enqueue({
|
|
data: [
|
|
{ date: '2024-06-15', amount: -100, description: raw1.description },
|
|
{ date: '2024-06-15', amount: -100, description: raw1.description },
|
|
],
|
|
error: null,
|
|
})
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches for any)
|
|
enqueue({ data: [], error: null })
|
|
|
|
// raw1: not in external_id set → content dedup matches (bookedCount=2 -> 1)
|
|
// raw2: not in external_id set → content dedup matches (bookedCount=1 -> 0)
|
|
// raw3: not in external_id set → content dedup exhausted → insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw1, raw2, raw3])
|
|
|
|
expect(result.duplicates).toBe(2)
|
|
expect(result.imported).toBe(1)
|
|
})
|
|
|
|
// -----------------------------------------------------------------------
|
|
// FX rate fetching (issue #442)
|
|
// Each non-SEK transaction must be priced at the rate of its OWN date,
|
|
// not the import date and not a single batch-level rate.
|
|
// -----------------------------------------------------------------------
|
|
it('fetches an exchange rate per unique (currency, date) pair', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw1 = makeRaw({ amount: -100, currency: 'USD', date: '2026-05-07', external_id: 'usd-a' })
|
|
const raw2 = makeRaw({ amount: -50, currency: 'USD', date: '2026-05-08', external_id: 'usd-b' })
|
|
const raw3 = makeRaw({ amount: -200, currency: 'EUR', date: '2026-05-07', external_id: 'eur-a' })
|
|
const raw4 = makeRaw({ amount: -300, currency: 'USD', date: '2026-05-07', external_id: 'usd-c' })
|
|
|
|
enqueue({ data: [], error: null }) // booked map
|
|
enqueue({ data: [], error: null }) // unbooked enable_banking map
|
|
enqueue({ data: [], error: null }) // supplier invoices
|
|
enqueue({ data: [], error: null }) // batch external_id dedup
|
|
enqueue({ data: makeTransaction({ id: 'tx-1' }), error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-2' }), error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-3' }), error: null })
|
|
enqueue({ data: makeTransaction({ id: 'tx-4' }), error: null })
|
|
|
|
mockFetchExchangeRate.mockResolvedValue({ currency: 'USD', rate: 9.2, date: '2026-05-07' })
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw1, raw2, raw3, raw4])
|
|
|
|
// 3 unique pairs: USD/2026-05-07, USD/2026-05-08, EUR/2026-05-07.
|
|
// raw4 reuses USD/2026-05-07 and must NOT trigger an extra fetch.
|
|
expect(mockFetchExchangeRate).toHaveBeenCalledTimes(3)
|
|
const pairs = mockFetchExchangeRate.mock.calls.map(([currency, date]) => ({
|
|
currency,
|
|
date: (date as Date).toISOString().split('T')[0],
|
|
}))
|
|
expect(pairs).toContainEqual({ currency: 'USD', date: '2026-05-07' })
|
|
expect(pairs).toContainEqual({ currency: 'USD', date: '2026-05-08' })
|
|
expect(pairs).toContainEqual({ currency: 'EUR', date: '2026-05-07' })
|
|
})
|
|
|
|
it('does not fetch a rate for SEK transactions', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -100, currency: 'SEK', date: '2026-05-07' })
|
|
|
|
enqueue({ data: [], error: null }) // booked
|
|
enqueue({ data: [], error: null }) // unbooked
|
|
enqueue({ data: [], error: null }) // suppliers
|
|
enqueue({ data: [], error: null }) // dedup
|
|
enqueue({ data: makeTransaction({ id: 'tx-sek' }), error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
expect(mockFetchExchangeRate).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('continues normally when booked transaction map query fails', async () => {
|
|
const { supabase, enqueue } = createQueueMockSupabase()
|
|
const raw = makeRaw({ amount: -200 })
|
|
const inserted = makeTransaction({ id: 'tx-mapfail', amount: -200 })
|
|
|
|
// Booked map query throws (caught by try/catch in buildExistingTransactionMap)
|
|
enqueue({ error: { message: 'Query failed' } })
|
|
// Unbooked bank-synced transaction map query
|
|
enqueue({ data: [], error: null })
|
|
// Supplier invoices fetch
|
|
enqueue({ data: [], error: null })
|
|
// Batch external_id dedup query (no matches)
|
|
enqueue({ data: [], error: null })
|
|
// Insert
|
|
enqueue({ data: inserted, error: null })
|
|
|
|
mockEvaluateMappingRules.mockResolvedValue(makeMappingResult({ confidence: 0.5 }))
|
|
|
|
const result = await ingestTransactions(supabase as never, COMPANY_ID, USER_ID, [raw])
|
|
|
|
expect(result.imported).toBe(1)
|
|
expect(result.duplicates).toBe(0)
|
|
})
|
|
})
|