Mattsson
6ea92f3152
Community PR #2416 by @olofpinzke, adopted and finished by maintainers (rebased so every commit is signed). Why the problem occurred: no Zettle integration; POS sales only reached the books as bank descriptors while Woo/Shopify already had order underlag via webshop_orders. The contributor's version also failed at the database (platform CHECKs listed only woocommerce/shopify), which the mocked unit tests never saw. What was simplified: reused the Orders/book/invoice path instead of a new inbox; Finance API payouts/fees deferred. Sales the one-account, revenue-per-rate model cannot book (split tender, gift cards, tips) import unbookable with a "bokför manuellt" title instead of guessing accounts. Reset parity uses the rename-and-wrap pattern instead of re-issuing the reset body. Why this solution: per-purchase rows give the radunderlag BFL verifikat need and the bulk-book path exists; daily kassarapport aggregation and Finance API fees/payouts are the follow-up (DECISIONS.md). Skeptic-refuted paths fixed before merge: concurrent refresh-token rotation (sync claim), cron offset paging (candidate snapshot), platform CHECKs, writer-role gate, migration-reset parity, white-label return origin re-validated at callback, VAT net from product rows. Not live until ZETTLE_CLIENT_ID / ZETTLE_CLIENT_SECRET / ZETTLE_CREDENTIALS_ENCRYPTION_KEY are set on Vercel and a Zettle developer app is registered with the callback redirect URI. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtYqzKPoTSRHskYYdf7MwB
87 lines
3.3 KiB
TypeScript
87 lines
3.3 KiB
TypeScript
import { describe, it, expect, vi } from 'vitest'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { getDashboardNavFlags } from '../nav-flags'
|
|
|
|
function makeSupabase(
|
|
rpcResult: { data?: unknown; error?: { code?: string; message?: string } | null },
|
|
probes: Record<string, unknown[]> = {},
|
|
) {
|
|
const from = vi.fn((table: string) => {
|
|
const chain: Record<string, unknown> = {}
|
|
const self: unknown = new Proxy(chain, {
|
|
get: (_t, prop) => {
|
|
if (prop === 'then') {
|
|
return (resolve: (v: unknown) => void) => resolve({ data: probes[table] ?? [], error: null })
|
|
}
|
|
return () => self
|
|
},
|
|
})
|
|
return self
|
|
})
|
|
const rpc = vi.fn(async () => ({ data: rpcResult.data ?? null, error: rpcResult.error ?? null }))
|
|
return { supabase: { from, rpc } as unknown as SupabaseClient, from, rpc }
|
|
}
|
|
|
|
describe('getDashboardNavFlags', () => {
|
|
it('reads both flags from the RPC row and only probes expense_claims beside it', async () => {
|
|
const { supabase, from, rpc } = makeSupabase({ data: [{ has_webshop: true, has_mileage_trips: false }] })
|
|
expect(await getDashboardNavFlags(supabase, 'c1')).toEqual({
|
|
hasWebshop: true,
|
|
hasMileageTrips: false,
|
|
hasExpenseClaims: false,
|
|
})
|
|
expect(rpc).toHaveBeenCalledWith('get_dashboard_nav_flags', { p_company_id: 'c1' })
|
|
// The Utlägg row is gated on existing claims (not part of the RPC): one
|
|
// limit-1 probe in the same wave, never the webshop/mileage tables.
|
|
expect(from.mock.calls.map((c) => c[0])).toEqual(['expense_claims'])
|
|
})
|
|
|
|
it('accepts a single-object payload and treats null flags as false', async () => {
|
|
const { supabase } = makeSupabase({ data: { has_webshop: null, has_mileage_trips: true } })
|
|
expect(await getDashboardNavFlags(supabase, 'c1')).toEqual({
|
|
hasWebshop: false,
|
|
hasMileageTrips: true,
|
|
hasExpenseClaims: false,
|
|
})
|
|
})
|
|
|
|
it('shows the Utlägg row once a claim exists', async () => {
|
|
const { supabase } = makeSupabase(
|
|
{ data: [{ has_webshop: false, has_mileage_trips: false }] },
|
|
{ expense_claims: [{ id: 'ec1' }] },
|
|
)
|
|
expect(await getDashboardNavFlags(supabase, 'c1')).toEqual({
|
|
hasWebshop: false,
|
|
hasMileageTrips: false,
|
|
hasExpenseClaims: true,
|
|
})
|
|
})
|
|
|
|
it.each(['PGRST202', '42883', '42501'])('falls back to the four probes when the RPC is unavailable (%s)', async (code) => {
|
|
const { supabase, from } = makeSupabase({ error: { code } }, { webshop_orders: [{ id: 'o1' }] })
|
|
expect(await getDashboardNavFlags(supabase, 'c1')).toEqual({
|
|
hasWebshop: true,
|
|
hasMileageTrips: false,
|
|
hasExpenseClaims: false,
|
|
})
|
|
expect(from.mock.calls.map((c) => c[0]).sort()).toEqual([
|
|
'expense_claims',
|
|
'mileage_trips',
|
|
'shopify_connections',
|
|
'webshop_orders',
|
|
'woocommerce_connections',
|
|
'zettle_connections',
|
|
])
|
|
})
|
|
|
|
it('degrades to hidden rows on any other error instead of probing', async () => {
|
|
const { supabase, from } = makeSupabase({ error: { code: '57014', message: 'timeout' } })
|
|
expect(await getDashboardNavFlags(supabase, 'c1')).toEqual({
|
|
hasWebshop: false,
|
|
hasMileageTrips: false,
|
|
hasExpenseClaims: false,
|
|
})
|
|
expect(from.mock.calls.map((c) => c[0])).toEqual(['expense_claims'])
|
|
})
|
|
})
|