* feat(dimensions): PR10 advanced — custom dimensions, hierarchy, account rules, commit enforcement The final rung of the dimensions ladder (dev_docs/dimensions_implementation_plan.md §7 row 10): - custom dimensions: POST /api/dimensions creates registry dims (next free SIE number >= 20 when omitted; explicit numbers allowed — SIE import already mints reserved ones); register gets a 'Ny dimension' dialog with a quiet Avancerat disclosure for the #UNDERDIM parent; GET now carries parent_sie_dim_no (the column + SIE round-trip existed since PR1/PR5 — this exposes it) - account_dimension_rules (migration 20260703120000): one rule per (account, dimension) — required / default / fixed, per-rule is_active, company-scoped RLS, composite FK to the registry, value-presence CHECK - enforcement, opt-in BY CONSTRUCTION (zero rules = engine byte-identical; deliberately NO settings toggle — a rule that exists but is ignored is worse than either extreme): default/fixed apply onto line bags at draft creation (fixed overwrites, default fills); required asserts at commitEntry with a Swedish MANDATORY_DIMENSION_MISSING naming every account + dimension; the bulk-book route runs the same policy before its RPC; storno/correction paths never pass through commitEntry so history always reverses regardless of policy; rule fetches fail open incl. thrown exceptions - chart of accounts: per-account Dimensionsregler section in EditAccountDialog (Krävs/Förval/Låst, value picker, pause switch), gated on the existing dimensions toggle, quiet when empty - pickers: LineDimensionFields is registry-driven (one combobox per active dimension, cached fetch, hardcoded 1/6 fallback) — every existing mount lights up custom dims with zero changes - agent briefing: per-dimension required_on_accounts/default_on_accounts so agents self-correct instead of bouncing off the policy error - rules CRUD API with existence/active/company validation and qualified DTO ids; firm_id FK deferred until the firms table lands (per plan) 39 new tests (pure-fn rules, engine enforcement, both new API surfaces, pg-real RLS/CHECK/cascade suite); full suite 6,791 green; migration replayed on a fresh container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: renumber migration to 20260703200000 — version collision with prod The concurrent session shipped pending_operations_add_link_document_to_voucher as 20260703120000 today; the Supabase preview branch (cloned from prod) rejected the duplicate version key. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: review round — auto-pick retry on collision, fail-open warnings, query schema - POST /api/dimensions retries once past a concurrent number claim when the number was auto-picked (explicit choices still 409) - every fail-open skip of the dimension-rules policy now logs a structured warning (engine draft/commit paths + bulk-book) — deliberate fail-open, but observable - GET /api/dimensions/rules validates its query through ListDimensionRulesQuerySchema instead of an inline regex Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
97 lines
3.2 KiB
TypeScript
97 lines
3.2 KiB
TypeScript
/**
|
|
* Client-side contract types for the dimensions registry API (PR2 of
|
|
* dev_docs/dimensions_implementation_plan.md).
|
|
*
|
|
* The routes live under /api/dimensions and are built against the same locked
|
|
* contract — this module codes against the contract, not the route files, so
|
|
* the register UI (DimensionsManager) and the shared picker (DimensionCombobox)
|
|
* can ship independently of the API package.
|
|
*/
|
|
|
|
export interface DimensionValueDto {
|
|
id: string
|
|
code: string
|
|
name: string
|
|
is_active: boolean
|
|
start_date: string | null
|
|
end_date: string | null
|
|
}
|
|
|
|
export interface DimensionDto {
|
|
id: string
|
|
/** SIE #DIM number (1 = Kostnadsställe, 6 = Projekt, 20+ = custom). */
|
|
sie_dim_no: number
|
|
name: string
|
|
resets_annually: boolean
|
|
is_system: boolean
|
|
is_active: boolean
|
|
sort_order: number
|
|
/** SIE #UNDERDIM parent — the sie_dim_no of the parent dimension, or null. */
|
|
parent_sie_dim_no: number | null
|
|
/** Sorted by code by the API. */
|
|
values: DimensionValueDto[]
|
|
}
|
|
|
|
export type DimensionRuleType = 'required' | 'default' | 'fixed'
|
|
|
|
/**
|
|
* Per-account dimension rule as served by GET /api/dimensions/rules —
|
|
* a flattened join row (rule + dimension + optional pinned value).
|
|
*/
|
|
export interface AccountDimensionRuleDto {
|
|
account_dimension_rule_id: string
|
|
account_number: string
|
|
dimension_id: string
|
|
sie_dim_no: number
|
|
dimension_name: string
|
|
rule_type: DimensionRuleType
|
|
value_id: string | null
|
|
value_code: string | null
|
|
value_name: string | null
|
|
is_active: boolean
|
|
}
|
|
|
|
/** SIE dimension number whose values carry start/end dates (Projekt). */
|
|
export const PROJECT_DIM_NO = 6
|
|
|
|
/**
|
|
* Strict Fortnox-compatible code format enforced by the API for user-created
|
|
* codes (the DB CHECK is deliberately looser so legacy free-text survives the
|
|
* backfill). Mirrored client-side for inline validation before POST.
|
|
*/
|
|
export const DIMENSION_CODE_PATTERN = /^[A-Za-z0-9ÅÄÖåäö_+\-]{1,20}$/
|
|
|
|
/**
|
|
* Load the company's dimension registry. The handler lazily seeds system dims
|
|
* 1/6 via ensure_company_dimensions, so the result always contains at least
|
|
* Kostnadsställe + Projekt. Throws the parsed error envelope on failure so
|
|
* callers can hand it straight to getErrorMessage().
|
|
*/
|
|
export async function fetchDimensions(): Promise<DimensionDto[]> {
|
|
const res = await fetch('/api/dimensions')
|
|
const json = await res.json().catch(() => null)
|
|
if (!res.ok) {
|
|
throw json ?? new Error('Failed to load dimensions')
|
|
}
|
|
return (json?.dimensions ?? []) as DimensionDto[]
|
|
}
|
|
|
|
let cachedDimensionsPromise: Promise<DimensionDto[]> | null = null
|
|
|
|
/**
|
|
* Module-level cached variant of fetchDimensions for high-mount-count
|
|
* consumers (one registry fetch per page load instead of one per line
|
|
* picker). A failed fetch clears the cache so the next mount retries.
|
|
* Registry mutations are rare enough that staleness within a page visit
|
|
* is acceptable — the register UI uses the uncached fetch.
|
|
*/
|
|
export function fetchDimensionsCached(): Promise<DimensionDto[]> {
|
|
if (!cachedDimensionsPromise) {
|
|
cachedDimensionsPromise = fetchDimensions().catch((err) => {
|
|
cachedDimensionsPromise = null
|
|
throw err
|
|
})
|
|
}
|
|
return cachedDimensionsPromise
|
|
}
|