Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
21 lines
1.0 KiB
TypeScript
21 lines
1.0 KiB
TypeScript
/**
|
|
* A draft invoice (or proforma / delivery note) is editable in place: header
|
|
* fields AND line items: only while it has no committed verifikat. A journal
|
|
* entry is created when the invoice is sent (mark-sent / send) or, for
|
|
* kontantmetoden, at payment; once one exists, BFL immutability applies and the
|
|
* invoice must be corrected with a credit note instead. A self-billed invoice we
|
|
* received is the counterparty's document: never editable here.
|
|
*
|
|
* This is the single source of truth for that predicate. The PATCH route
|
|
* (app/api/invoices/[id]/route.ts) enforces it server-side; the detail and edit
|
|
* pages call it only to avoid opening a dead form: they are UX hints, not the
|
|
* trust boundary. Keeping all three on one function stops the rule from drifting.
|
|
*/
|
|
export function isEditableInvoiceDraft(invoice: {
|
|
status: string
|
|
journal_entry_id?: string | null
|
|
is_self_billed?: boolean | null
|
|
}): boolean {
|
|
return invoice.status === 'draft' && !invoice.journal_entry_id && !invoice.is_self_billed
|
|
}
|