* feat(mcp): article-aware invoice updates with gnubok_get_invoice round trip and rebooking preview
gnubok_update_invoice items are a FULL REPLACE, had no article fields, and
no MCP tool returned invoice lines, so a quantity fix rebuilt from memory
wrote article_id/revenue_account null and reverted vat_rate to the customer
default: revenue silently moved from the article account (3041) to the
VAT-derived default, invisible in the approval preview.
- gnubok_get_invoice (invoices:read, search-only): header plus every line
with article_id, revenue_account, vat_rate, dimensions, editable_draft
- gnubok_update_invoice lines accept article_id with the same prefill and
default-set VAT adoption guard as create; permitted-set VAT gate at
staging; preview carries the new lines' effective booking and a snapshot
of the lines being replaced
- commitUpdateInvoice scope-checks staged article ids like create does
- OperationPreview: update_invoice preview (current vs new lines, header
diffs, totals); create_invoice lines show VAT rate and posting account
- invoicing skill points at the read-before-replace round trip
Closes#1642
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
* fix(mcp): use roundOre for update-invoice preview totals so the ore ratchet stays at baseline
The preview-building code in gnubok_update_invoice introduced five naive
Math.round(x * 100) / 100 occurrences, tripping check:guards
(naive-ore-round 627 vs baseline 622) and failing Core Build on PR #1993.
roundOre from @/lib/money is the sanctioned helper and was already
imported in this file.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
* fix(mcp): make the invoice round trip lossless for text, ROT/RUT and accrual lines
Skeptic review of #1993 found three round-trip breaks for web-created
drafts edited via MCP (the exact silent-loss class issue #1642 reports):
- Text rows: the update pre-gate and resolveInvoiceLineFromArticle
rejected quantity <= 0 before looking at line_type, so any draft with
a free-text spacer row could not be edited at all, and the natural
agent recovery (drop the row and retry the FULL REPLACE) silently
deleted invoice content. Text rows are now exempt from the
quantity/description/unit/price gates (CreateInvoiceItemSchema
parity), normalized to the zeroed stored shape, excluded from the
staged totals and the VAT gate (commitCreateInvoice billableItems
parity), and line_type is declared on both the create and update item
schemas.
- ROT/RUT: gnubok_get_invoice omitted housing_designation,
apartment_number and brf_org_number, so an items replace on a ROT
draft either failed AFTER approval ('Fastighetsbeteckning krävs för
ROT-avdrag') or, for a schema-conformant agent, silently stripped the
avdrag and the stored personnummer. The three property columns
(property identifiers, never the personnummer ciphertext) are now
returned per line, the deduction fields are declared on the update
item schema, deduction_type rides on the current_items snapshot and
the new-lines preview, and a staging-time completeness gate
(arbetstyp/timmar via validateDeductionLines, fastighetsbeteckning
for ROT, personnummer availability on the invoice or the individual's
kundkort) surfaces the failure to the agent instead of the approver.
- Declared-schema gap: revenue_account and the accrual fields were
accepted on pass-through but undeclared, so a schema-conformant agent
dropped a manual posting-account override or a periodisering on
pass-back. They are now declared on the update item schema
(revenue_account also on create; create deliberately does NOT declare
deduction/accrual fields because commitCreateInvoice drops them), and
the approval preview shows ROT/RUT-avdrag and the periodisering
period per line.
tools/list ceiling check after the two new create-schema properties:
63337 of 63400.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg
17caf9d80a