Files
accounted/lib/bookkeeping/bas-reference.ts
T
Jakob Wennberg 1a41119682 perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)
* perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline

Two chunks rode along in the first-load JS of almost every dashboard route:
the full BAS 2026 chart (315 KB uncompressed, in 81 route manifests) and
the browser polyfill for Node's crypto/vm/Buffer (327 KB, in 26 routes
incl. login and register). Neither was needed on first paint; both got
there through static imports of helpers that happen to live next to code
that needs the data or the builtin.

Node polyfill (4 pure splits, behaviour unchanged, re-exported from the
original modules for server callers):
- lib/auth/bankid-flags.ts: isBankIdEnabled (login, register, security
  settings imported it from bankid.ts, which imports crypto).
- lib/import/bank-file/formats.ts: the format registry + detection (the
  import history imported getFormat from parser.ts, which hashes).
- lib/salary/personnummer-format.ts: parsing/validation/formatting (the
  employee forms reached the encrypting personnummer.ts via tax-column).
- lib/auth/api-key-scopes.ts: scope catalogue, groups, tool map, helpers
  (the API key panel imported STAGING_SCOPES from the key generator).

BAS chart:
- lib/bookkeeping/bas-lazy.ts + use-bas-reference.ts: the chart becomes a
  dynamic import, fetched once per session after first paint; components
  that show BAS names/descriptions call useBasReference() and re-render
  when it lands. Until then (and on the server) only the hardcoded
  account-descriptions answer, so SSR and hydration agree.
- lib/bookkeeping/bas-labels.ts: class/group labels out of bas-reference.ts
  (account-descriptions needed a label and paid for the whole chart).
- lib/bookkeeping/bas-account-numbers.ts (generated, ~11 KB) +
  scripts/generate-bas-account-numbers.ts (--check) + parity test:
  isStandardBASAccountNumber for AddAccountDialog/ChartOfAccountsManager.
- lib/bookkeeping/account-classifier-{heuristic,client}.ts: the BAS-aligned
  heuristic shared by the server classifier and a client variant that uses
  the lazy chart.
- lib/bookkeeping/invoice-accounts.ts: INVOICE_FX_RATE_MISSING,
  InvoiceFxRateMissingError, getRevenueAccount, getOutputVatAccount out of
  invoice-entries.ts, whose engine import pulled account-backfill and the
  chart into SendInvoiceDialog/PaymentBookingDialog.
- CorrectOpeningBalanceDialog re-seeds names when the chart lands;
  OpeningBalanceRowEditor builds its Fuse indexes lazily; the
  ChartOfAccountsManager BAS-katalog tab awaits the chunk.

Tooling:
- scripts/perf/client-import-closure.mjs: static import closure of every
  'use client' module with the shortest chain to a target (file or bare
  specifier); found every path above without a build.
- scripts/checks/client-node-builtin.mjs wired into check:guards: a client
  module reaching a Node builtin is a hard failure (0 today).

Left as is: invoices/[id], its credit page and SendInvoiceDialog still
reach the chart through lib/invoices/issue-credit-note -> invoice-entries
-> engine -> account-backfill; splitting the engine is out of scope here.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(perf): unambiguous import-edge regex in the closure walker (CodeQL js/redos)

One quantifier per span: a greedy [^'"]* up to the specifier quote, which it
cannot cross, so a run of whitespace has a single parse. Same edges as
before (multi-line named imports, re-exports, side-effect imports; type-only
imports still skipped).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 15:07:49 +02:00

100 lines
3.5 KiB
TypeScript

/**
* BAS Reference Data for Swedish Accounting
*
* Full BAS Kontoplan 2026 (~1,276 accounts) organized by account class.
* Data files live in ./bas-data/ and are aggregated here.
*
* Reference: BAS Kontoplan 2026 v1.0
* SRU codes follow Skatteverket's SRU specification for NE and INK2 forms.
*/
// ---------------------------------------------------------------------------
// Types
// ---------------------------------------------------------------------------
export interface BASReferenceAccount {
account_number: string
account_name: string
account_class: number
account_group: string
account_type: 'asset' | 'liability' | 'equity' | 'revenue' | 'expense' | 'untaxed_reserves'
normal_balance: 'debit' | 'credit'
description: string
sru_code: string | null
k2_excluded: boolean
}
// ---------------------------------------------------------------------------
// Data (imported from per-class data files)
// ---------------------------------------------------------------------------
export { BAS_REFERENCE } from './bas-data'
// ---------------------------------------------------------------------------
// Class & Group Labels
// ---------------------------------------------------------------------------
// Labels live in ./bas-labels (a few KB, no data) so client code can import
// them without this module's index over the full chart. Re-exported here.
export { ACCOUNT_CLASS_LABELS, ACCOUNT_GROUP_LABELS } from './bas-labels'
// ---------------------------------------------------------------------------
// Lookup indexes (lazy-initialized for performance)
// ---------------------------------------------------------------------------
// Import BAS_REFERENCE for use in indexes (re-exported above for consumers)
import { BAS_REFERENCE } from './bas-data'
let _byAccountNumber: Map<string, BASReferenceAccount> | null = null
let _byClass: Map<number, BASReferenceAccount[]> | null = null
function getByAccountNumberIndex(): Map<string, BASReferenceAccount> {
if (!_byAccountNumber) {
_byAccountNumber = new Map()
for (const account of BAS_REFERENCE) {
_byAccountNumber.set(account.account_number, account)
}
}
return _byAccountNumber
}
function getByClassIndex(): Map<number, BASReferenceAccount[]> {
if (!_byClass) {
_byClass = new Map()
for (const account of BAS_REFERENCE) {
const existing = _byClass.get(account.account_class) ?? []
existing.push(account)
_byClass.set(account.account_class, existing)
}
}
return _byClass
}
// ---------------------------------------------------------------------------
// Helper functions
// ---------------------------------------------------------------------------
/**
* Look up a single BAS reference account by its account number.
* Returns undefined if the account number is not in the reference data.
*/
export function getBASReference(accountNumber: string): BASReferenceAccount | undefined {
return getByAccountNumberIndex().get(accountNumber)
}
/**
* Get all BAS reference accounts for a given account class (1-8).
* Returns an empty array if the class has no accounts in the reference data.
*/
export function getBASReferenceByClass(accountClass: number): BASReferenceAccount[] {
return getByClassIndex().get(accountClass) ?? []
}
/**
* Check whether an account number exists in the BAS reference data.
* Useful for validating that a user-entered account number is a standard BAS account.
*/
export function isStandardBASAccount(accountNumber: string): boolean {
return getByAccountNumberIndex().has(accountNumber)
}