Jakob WennbergandClaude Opus 4.8
2d6ddeafc5
* feat(import/export): article import + register export (xlsx/csv)
Add CSV/Excel import for the article register (artiklar), mirroring the
existing customer/supplier import pipeline, plus Excel + CSV export for
articles, customers and suppliers.
Import (lib/import/articles + app/api/import/articles):
- Column auto-detection tuned to Fortnox/Visma/Bokio export headers,
Swedish-decimal price parsing, VAT snapped to {0,6,12,25}, type/unit
normalization.
- Dedup by article number then name; 23505 soft-skip; auto-number
backfill; revenue-account override kept only when active, otherwise
dropped with a warning (never mutates the chart of accounts).
- New "Artiklar" flow in the /import hub.
Export (app/api/export/* + lib/export/register-export):
- Read-only xlsx (default) / csv (?format=csv, UTF-8 BOM) downloads.
- Headers chosen so files round-trip back through the importer.
- "Exportera" menu added to the articles, customers and suppliers pages.
Refs #746. Direct Fortnox/Visma API article fetch tracked in #749.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(import/export): address PR review — lint ratchet + export hardening
- xlsx-export: keep `SheetSpec<any>` on the eslint-disabled line (fixes the
core-only lint ratchet regression: no-explicit-any 16 -> 15) and define
UTF8_BOM as an explicit `` escape instead of a raw BOM character.
- export routes (articles/customers/suppliers): move the data queries inside
the try/catch, add `Cache-Control: no-store`, and emit a `register exported`
audit log line (entity, format, rowCount).
- articles parse route: validate `column_overrides` against a Zod schema before
trusting it to drive the parser.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(import): drop öre-round pattern on article column-detector confidence
The confidence score is a 0-1 heuristic, not money, and is only compared
against the 0.8 skip-mapping threshold. Removing the Math.round(x*100)/100
form clears the core-only antipattern ratchet (naive-ore-round 660 -> 659).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(import): flag adjusted VAT rows in the article import edit step
Surface VAT snapping/defaulting per row, not just as a file-level warning:
the parser sets `vat_rate_adjusted`, the edit step highlights those rows'
VAT selector and shows a count banner, and confirming a rate clears the flag.
Addresses the Swedish-compliance review note that silent snapping could
otherwise store a wrong VAT rate at scale.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
80 lines
2.4 KiB
TypeScript
80 lines
2.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import * as XLSX from 'xlsx'
|
|
import { createMockRequest, parseJsonResponse, createQueuedMockSupabase } from '@/tests/helpers'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
const mockFetchAllRows = vi.fn()
|
|
vi.mock('@/lib/supabase/fetch-all', () => ({
|
|
fetchAllRows: (...a: unknown[]) => mockFetchAllRows(...a),
|
|
}))
|
|
|
|
import { GET } from '../route'
|
|
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
const SUPPLIER = {
|
|
id: 's1',
|
|
name: 'Leverantör AB',
|
|
supplier_type: 'swedish_business',
|
|
org_number: '5560217780',
|
|
vat_number: 'SE556021778001',
|
|
email: 'faktura@lev.se',
|
|
phone: null,
|
|
address_line1: null,
|
|
address_line2: null,
|
|
postal_code: null,
|
|
city: 'Malmö',
|
|
country: 'Sweden',
|
|
bankgiro: '5050-1055',
|
|
plusgiro: null,
|
|
bank_account: null,
|
|
iban: null,
|
|
bic: null,
|
|
default_payment_terms: 30,
|
|
default_currency: 'SEK',
|
|
notes: null,
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
mockFetchAllRows.mockResolvedValue([SUPPLIER])
|
|
})
|
|
|
|
describe('GET /api/export/suppliers', () => {
|
|
it('returns 401 when unauthenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
const res = await GET(createMockRequest('/api/export/suppliers'))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(401)
|
|
})
|
|
|
|
it('returns an xlsx supplier register with banking columns', async () => {
|
|
enqueue({ data: { company_name: 'Acme AB' } })
|
|
const res = await GET(createMockRequest('/api/export/suppliers'))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Disposition')).toContain('leverantorer-')
|
|
|
|
const buf = Buffer.from(await res.arrayBuffer())
|
|
const wb = XLSX.read(new Uint8Array(buf), { type: 'array' })
|
|
const sheet = wb.Sheets[wb.SheetNames[0]]
|
|
const rows = XLSX.utils.sheet_to_json<string[]>(sheet, { header: 1 })
|
|
const headers = (rows[0] as string[]).map(String)
|
|
expect(headers).toContain('Bankgiro')
|
|
expect(headers).toContain('Valuta')
|
|
expect((rows[1] as string[])).toContain('Leverantör AB')
|
|
})
|
|
})
|