* feat(reconciliation): match migrated bank history against imported SIE verifikat A first-class Fortnox/SIE migrator path: after SIE import plus bank connect or bank CSV upload, historical bank rows are auto-matched (>= 0.9) or suggestion-matched (0.75-0.89, persisted for review) against the imported verifikat, with a guided review surface, instead of landing as anonymous "Att bokfora" rows. Phase 0: per-cash-account unattended sweep (fixes #1298 cross-account pooling); widen payment_match_log action CHECK with linked_to_existing_voucher (silently unlogged since March). Phase 1: potential_journal_entry_id/method/confidence on transactions with CHECK + invalidation triggers; persistSuggestions in runReconciliation; sweep after bank CSV import with SIE overlap (suppressing auto-categorization); sweep summaries stamped on bank_connections and bank_file_imports; POST /api/reconciliation/bank/confirm-suggestions with per-pair server-side revalidation (voucher consumption + bank-leg amount and direction). Phase 2: "Granska forslag" review tab on Transactions with chunked bulk confirm, per-row fallbacks, "Kor matchning igen" (all_accounts sweep mode, mutually exclusive with dry_run), attn line, pre-migration row marker. Phase 3: ImportResultStep dual CTA (bank connect + CSV), migrator variant of the account-picker #917 nudge, sweep outcome on the onboarding checklist bank step. Non-selection apply runs on /api/reconciliation/bank/run now floor at 0.9 and persist the review band instead of auto-committing fuzzy matches. Migrations already applied to staging under the same versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): resolve PR review findings in one pass Swedish accounting review (both previously-deferred holes closed): - runReconciliation's >= 0.9 auto-apply now writes 'matched' to payment_match_log (behandlingshistorik, BFNAR 2013:2 kap 8); the bus event alone lands in the 30-day event_log and is not an audit record. - The three match-route storno-conflict branches detach reconciliation links via unlinkReconciliation instead of storno-reversing the linked verifikat: a reconciliation link points at an independent verifikat that may evidence other affarshandelser, and a wholesale reversal is an over-broad rattelse (BFL 5 kap 5 §). - Historical gap quantified on prod (read-only, recorded in DECISIONS): 762 unlogged manual links across 52 companies since 2026-03-23. CodeRabbit: - confirm-suggestions route: maxDuration 300 for full 500-item batches. - AccountPickerDialog: migrator-nudge buttons set lookbackTouched so the async gap-fill probe cannot override an explicit choice. - enable-banking post-backfill sweep: persistSuggestions so the review band is not dropped. - bank-file execute: sie_sweep stamp errors are logged, not swallowed. - ImportResultStep: sandbox keeps the CSV CTA (file import works there). - payment_match_log CHECK swap: NOT VALID + VALIDATE, no table scan under ACCESS EXCLUSIVE. - logMatchEvent calls awaited (serverless can freeze unawaited work). - DECISIONS.md stale version reference annotated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): defer reconciliation-link detach until the match commits Round-2 review findings: - CodeRabbit: the eager unlinkReconciliation call could orphan a transaction if the match flow failed after it. All three match routes now persist NOTHING up front: the final transaction update overwrites journal_entry_id and clears reconciliation_method in the same write, so any failure in between leaves the existing link intact. The release is logged as 'unmatched' after the commit. - Swedish review: the auto_suggested logMatchEvent in runReconciliation is now awaited like every other audit write. - DECISIONS entry split into compliance/CodeRabbit lines and updated to describe the deferred detach. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): literal reconciliation_method payloads for the phantom-column scanner The conditional spreads introduced with the deferred detach pushed the scanner's unresolvable-expression count past its ceiling (380 > 378). reconciliation_method: null is correct unconditionally on a confirmed invoice/supplier match (null is already the value on every row that was not reconciliation-linked), so the payloads become plain literals the guard can verify. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
183 lines
7.3 KiB
TypeScript
183 lines
7.3 KiB
TypeScript
'use client'
|
|
|
|
import { useState } from 'react'
|
|
import { useTranslations } from 'next-intl'
|
|
import { MoreHorizontal, Loader2 } from 'lucide-react'
|
|
import { Button } from '@/components/ui/button'
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from '@/components/ui/dropdown-menu'
|
|
import { EmptyState } from '@/components/ui/empty-state'
|
|
import { TH_CLASS, TD_CLASS } from '@/components/ui/dry-table'
|
|
import { formatCurrency, formatDate, cn } from '@/lib/utils'
|
|
import type { TransactionWithInvoice } from './transaction-types'
|
|
|
|
/**
|
|
* "Granska migrerad historik": the review surface for journal-entry match
|
|
* suggestions the reconciliation sweep persisted (the 0.75-0.89 band). Each
|
|
* row shows the bank transaction beside its suggested verifikat; confirming
|
|
* goes through the server-side revalidating bulk endpoint, so a stale pair
|
|
* degrades to a reported skip, never a wrong link. Per-row fallbacks: open the
|
|
* match dialog to pick another verifikat, or reject the suggestion (the row
|
|
* returns to the ordinary "Att bokföra" flow as backstop).
|
|
*/
|
|
interface SuggestionReviewListProps {
|
|
items: TransactionWithInvoice[]
|
|
/** Bulk/single confirm: resolves when the API call and list refresh are done. */
|
|
onConfirm: (transactionIds: string[]) => Promise<void>
|
|
onReject: (transactionIds: string[]) => Promise<void>
|
|
onOpenMatchVoucher: (tx: TransactionWithInvoice) => void
|
|
onRerunMatching: () => Promise<void>
|
|
rerunning: boolean
|
|
}
|
|
|
|
export function SuggestionReviewList({
|
|
items,
|
|
onConfirm,
|
|
onReject,
|
|
onOpenMatchVoucher,
|
|
onRerunMatching,
|
|
rerunning,
|
|
}: SuggestionReviewListProps) {
|
|
const t = useTranslations('tx_review')
|
|
const [busyIds, setBusyIds] = useState<Set<string>>(new Set())
|
|
const [bulkBusy, setBulkBusy] = useState(false)
|
|
|
|
const runRows = async (ids: string[], action: (ids: string[]) => Promise<void>) => {
|
|
setBusyIds((prev) => new Set([...prev, ...ids]))
|
|
try {
|
|
await action(ids)
|
|
} finally {
|
|
setBusyIds((prev) => {
|
|
const next = new Set(prev)
|
|
for (const id of ids) next.delete(id)
|
|
return next
|
|
})
|
|
}
|
|
}
|
|
|
|
const confirmAll = async () => {
|
|
setBulkBusy(true)
|
|
try {
|
|
await runRows(items.map((i) => i.id), onConfirm)
|
|
} finally {
|
|
setBulkBusy(false)
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<div className="flex flex-wrap items-center justify-between gap-3">
|
|
<p className="text-[12.5px] text-muted-foreground">
|
|
{t('intro', { count: items.length })}
|
|
</p>
|
|
<div className="flex items-center gap-2">
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={rerunning || bulkBusy}
|
|
onClick={() => void onRerunMatching()}
|
|
>
|
|
{rerunning && <Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />}
|
|
{t('rerun')}
|
|
</Button>
|
|
<Button size="sm" disabled={bulkBusy || items.length === 0} onClick={() => void confirmAll()}>
|
|
{bulkBusy && <Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />}
|
|
{t('confirm_all', { count: items.length })}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
|
|
{items.length === 0 ? (
|
|
<EmptyState title={t('empty_title')} description={t('empty_description')} />
|
|
) : (
|
|
<div className="overflow-x-auto">
|
|
<table className="w-full border-collapse text-[13px]">
|
|
<thead>
|
|
<tr>
|
|
<th className={TH_CLASS}>{t('th_date')}</th>
|
|
<th className={TH_CLASS}>{t('th_description')}</th>
|
|
<th className={cn(TH_CLASS, 'text-right')}>{t('th_amount')}</th>
|
|
<th className={TH_CLASS}>{t('th_suggestion')}</th>
|
|
<th className={TH_CLASS} aria-label={t('th_actions')} />
|
|
</tr>
|
|
</thead>
|
|
<tbody className="stagger-enter">
|
|
{items.map((tx) => {
|
|
const busy = busyIds.has(tx.id)
|
|
const voucher = tx.potential_voucher
|
|
return (
|
|
<tr key={tx.id} className="group transition-colors duration-150 hover:bg-secondary/35">
|
|
<td className={cn(TD_CLASS, 'whitespace-nowrap tabular-nums text-muted-foreground')}>
|
|
{formatDate(tx.date)}
|
|
</td>
|
|
<td className={cn(TD_CLASS, 'max-w-[280px]')}>
|
|
<span className="block truncate">{tx.description}</span>
|
|
</td>
|
|
<td className={cn(TD_CLASS, 'whitespace-nowrap text-right tabular-nums')}>
|
|
{formatCurrency(tx.amount, tx.currency)}
|
|
</td>
|
|
<td className={cn(TD_CLASS, 'whitespace-nowrap')}>
|
|
{voucher ? (
|
|
<span className="tabular-nums">
|
|
{voucher.voucher_series}-{voucher.voucher_number}
|
|
<span className="text-muted-foreground">
|
|
{' · '}
|
|
{formatDate(voucher.entry_date)}
|
|
{typeof tx.potential_match_confidence === 'number' && (
|
|
<> {' · '}{Math.round(tx.potential_match_confidence * 100)} %</>
|
|
)}
|
|
</span>
|
|
</span>
|
|
) : (
|
|
<span className="text-muted-foreground">{t('suggestion_gone')}</span>
|
|
)}
|
|
</td>
|
|
<td className={cn(TD_CLASS, 'whitespace-nowrap text-right')}>
|
|
<div className="flex items-center justify-end gap-1">
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
className="h-7 px-3.5 text-xs"
|
|
disabled={busy || bulkBusy || !voucher}
|
|
onClick={() => void runRows([tx.id], onConfirm)}
|
|
>
|
|
{busy ? <Loader2 className="h-3.5 w-3.5 animate-spin" /> : t('confirm')}
|
|
</Button>
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
size="icon"
|
|
variant="ghost"
|
|
className="h-7 w-7"
|
|
disabled={busy || bulkBusy}
|
|
aria-label={t('row_menu')}
|
|
>
|
|
<MoreHorizontal className="h-4 w-4" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end">
|
|
<DropdownMenuItem onClick={() => onOpenMatchVoucher(tx)}>
|
|
{t('open_match_dialog')}
|
|
</DropdownMenuItem>
|
|
<DropdownMenuItem onClick={() => void runRows([tx.id], onReject)}>
|
|
{t('reject')}
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
)
|
|
})}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
)}
|
|
</div>
|
|
)
|
|
}
|